Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 expands the ability to upload remote_files for valkyrie #967

Merged
merged 7 commits into from
Aug 14, 2024

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Aug 5, 2024

Previously this code strictly downloaded from s3 buckets. This was limiting, and expands the ability to import remote files without s3, and override thumbnail urls if one is provided.

Issue:

Previously this code strictly downloaded from s3 buckets. This was limiting, and expands the ability to import remote files without s3.
@ShanaLMoore ShanaLMoore added the patch-ver for release notes label Aug 6, 2024
ShanaLMoore and others added 6 commits August 6, 2024 12:14
- Provides a valkyrized way to import from a remote url.
- Supports additional file set arguments if present.
- Adds filename to Hyrax's UploadedFile table, to allow overriding of
carrierwave's default file name behavior.

refs
- scientist-softserv/adventist_knapsack#708
- scientist-softserv/adventist_knapsack#723
error: NoMethodError: undefined method `column_exists' for #<AddFileNameToUploadedFiles:0x000055d8c48ea0b0 @name="AddFileNameToUploadedFiles", @Version=20240806161142, @connection=nil>
@ShanaLMoore ShanaLMoore marked this pull request as ready for review August 13, 2024 23:25
@ShanaLMoore ShanaLMoore changed the title 🧹 WIP expands the ability to upload remote_files for valkyrie 🧹 expands the ability to upload remote_files for valkyrie Aug 13, 2024
@ShanaLMoore ShanaLMoore merged commit 176b11a into main Aug 14, 2024
6 checks passed
@ShanaLMoore ShanaLMoore deleted the handle-remote-files-for-valkyrie branch August 14, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants