Access the default split pattern from the parser instead of the config #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transfer responsibility of accessing the split pattern from the config to the ApplicationParser. This enables the default split pattern to be overwritten Hyku will soon get an `Account` setting that allows for per-tenant overrides for the default split pattern. This change enables that feature The default value is still set in the config. Existing installations should see no difference in behavior; this change is backwards-compatible
|
The sister Hyku PR for this change was closed / replaced by: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
Transfer responsibility of accessing the split pattern from the config to the
ApplicationParser. This enables the default split pattern to be overwrittenHyku will soon get an
Accountsetting that allows for per-tenant overrides for the default split pattern. This change enables that featureThe default value is still set in the config. Existing installations should see no difference in behavior; this change is backwards-compatible