Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AddObjectToObject service calls with += #151

Closed
elrayle opened this issue Jul 13, 2015 · 1 comment
Closed

Replace AddObjectToObject service calls with += #151

elrayle opened this issue Jul 13, 2015 · 1 comment
Assignees
@elrayle

Comments

@elrayle
Copy link
Contributor

elrayle commented Jul 13, 2015

AddObjectToObject was removed from PCDM in PR samvera/hydra-pcdm#118.

Old syntax:

Hydra::PCDM::AddObjectToObject.call( parent_generic_work, child_generic_file )

New syntax:

parent_generic_work += child_generic_file

Unpinning PCDM version in Gemfile will reveal ~45 test failures related to the removal of AddObjectToObject. See issue #150
@elrayle elrayle mentioned this issue Jul 13, 2015
Closed
@elrayle elrayle added this to the summer-2015 milestone Jul 13, 2015
@mjgiarlo mjgiarlo removed this from the summer-2015 milestone Jul 13, 2015
@elrayle elrayle self-assigned this Jul 20, 2015
elrayle added a commit that referenced this issue Jul 20, 2015
@elrayle
First optimization pass to change create to new whenever possible
6ea9f79 
Partial fix for issue #156 - optimize tests

Also includes fix for issue #151 - remove usage of AddObjectToObject
@elrayle elrayle mentioned this issue Jul 20, 2015
Merged
@elrayle
Copy link
Contributor Author

elrayle commented Jul 21, 2015

Fixed by #157

@elrayle elrayle closed this as completed Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elrayle elrayle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjgiarlo @elrayle