I903 remove bulkrax_identifier dependency #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanaLMoore
force-pushed
the
i903-move-find-by-bulkrax-identifier-to-bulkrax
branch
from
a9d427b
to
f01e775
Compare
bulrax_identifier is not a required property. Each client should set their desired source_identifier in their application. Issue: - scientist-softserv/hykuup_knapsack#136
ShanaLMoore
force-pushed
the
i903-move-find-by-bulkrax-identifier-to-bulkrax
branch
from
f01e775
to
887fbf2
Compare
jeremyf
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bulrax_identifier is not a required property. Each client should set their desired source_identifier in their application.
find_by_bulkrax_identifier code should be moved into Bulkrax anyways.
Issue:
Bulkrax PR: