Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the deletion of collections 500 (#6362). #6367

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

bwatson78
Copy link
Contributor

Fixes

Fixes #6362

Summary

Fixes the deletion of collections 500 errors.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

Pre-req: create a collection or have manager access to a collection

  • In valkyrie/fedora (sirenia), log in and navigate to Dashboard -> Collections
  • Click on the title of a collection
  • Click "Delete Collection"
  • Click "OK"
  • No errors should occur. Collection should be removed in all possible storage locations.

Type of change (for release notes)

  • notes-bugfix Bug Fixes
  • notes-valkyrie Valkyrie Progress

Detailed Description

The objects being queried are missing from their stores when we attempt to eliminate their children. This causes errors that redirects the user to the edit page of an object that no longer exists. This PR pulls the objects to remove first, deletes second.

Changes proposed in this pull request:

  • Retrieves the object child members before deleting the objects from their respective stores.
  • Passes along a members variable that contains the intended FileSets or Works.
  • Switches the order of deletion to ACL first, Work second.

@samvera/hyrax-code-reviewers

@dlpierce dlpierce merged commit a06ea55 into main Oct 18, 2023
@dlpierce dlpierce deleted the fix_delete_collections_bug_6362 branch October 18, 2023 04:55
@dlpierce dlpierce added the notes-valkyrie Release Notes: Valkyrie specific label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug notes-valkyrie Release Notes: Valkyrie specific valkyrie-fedora
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete collections in valkyrie/fedora
2 participants