Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-382 - Research - updating volume after cherrypicking #4412

Open
1 of 4 tasks
KatyTaylor opened this issue Oct 11, 2024 · 3 comments · May be fixed by #4529
Open
1 of 4 tasks

Y24-382 - Research - updating volume after cherrypicking #4412

KatyTaylor opened this issue Oct 11, 2024 · 3 comments · May be fixed by #4529
Assignees
Labels
Cherrypicking Research Research only Size: M Medium - medium effort & risk

Comments

@KatyTaylor
Copy link
Contributor

KatyTaylor commented Oct 11, 2024

Description
As an SSR (Liz C) I would like to know when well volumes in Sequencescape are updated after cherrypicks, so that I am confident when re-picking from a well that the remaining volume shown is correct.

Acceptance Criteria
The following outputs from the research are produced:

  • Find where in the code the volume update is done after cherrypicking. N.B. I think it doesn't happen during the cherrypicking pipeline, but rather during the bed verification that follows.
  • Check whether anything affects whether that volume update happens e.g. which option they pick out of ‘pick by volume (μl)’, ‘pick by concentration (ng/μl)’ and ‘pick by amount (ng)’.
  • Document findings to an appropriate level in the user facing documentation produced by this story.
  • Look into Liz C's findings when she tested this - get spreadsheet from Katy - not sure if it's appropriate to attach. Are there any bugs here? If so, update this placeholder story with what needs to be fixed.

Who the primary contacts are for this work
Katy

Knowledge or Stake holders
Liz C

Additional context or information
Related stories:

@KatyTaylor KatyTaylor added Research Research only Size: M Medium - medium effort & risk labels Oct 11, 2024
@psd-issuer psd-issuer bot changed the title Updating volume after cherrypicking Y24-382 - Updating volume after cherrypicking Oct 11, 2024
@KatyTaylor KatyTaylor changed the title Y24-382 - Updating volume after cherrypicking Y24-382 - Research - updating volume after cherrypicking Oct 11, 2024
@StephenHulme StephenHulme self-assigned this Nov 11, 2024
@StephenHulme
Copy link
Contributor

StephenHulme commented Nov 12, 2024

@StephenHulme
Copy link
Contributor

Confirmed that the code in app/models/cherrypicking_pipeline.rb::CherrypickingPipeline.robot_verified! is executed on robot verification through Sample Management (Lab View) > Bed Verification.

Once this has been completed, then a Robot verification completed and source volumes updated. event appears at the bottom of the Batch page.

Screenshot 2024-11-19 at 16 27 28 Screenshot 2024-11-19 at 16 27 50

@StephenHulme
Copy link
Contributor

StephenHulme commented Nov 27, 2024

Calculations (and explanations) for volumes can be found in app/models/cherrypick/volume_by_micro_litre.rb and sibling files. This is also where validity checks are for volume being defined. This is likely to be particularly helpful for Y24-383.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cherrypicking Research Research only Size: M Medium - medium effort & risk
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants