Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-420 - As LeGo, we would like the new study set up fields to be added to the MLWH #4444

Open
11 tasks
harrietc52 opened this issue Oct 23, 2024 · 0 comments
Open
11 tasks
Labels
LeGo Size: S Small - low effort & risk

Comments

@harrietc52
Copy link
Contributor

harrietc52 commented Oct 23, 2024

User story
As LeGo, we would like the new study set up fields to be added to the MLWH, so that we can pull the data into eDAM and create DAA’s from it.

Currently, a script from eDAM pulls in the current study data from the MLWH study table at 2am everyday. It then uses this to create the DAA. They would like to pull in the other eDAM fields specified in Y24-419

When a Study in Sequencescape has been updated, the script in eDAM removes the existing studies in eDAM first, before inserting the studies obtained from MLWH, so all the studies in the system are up to date. However, DAAs that have already been approved do not get updated. This needs to be tested so all DAAs get updated

For the final production system to be successful, it is important to ensure that Quan (Data Release Team) and LeGo are aware that they are responsible for checking that every new Study created in EBI has a Legal Agreement (DAA) in eDAM. We are putting in place the restrictions so that all the EGA data must be added to Sequencescape on Study creation, and that the EGA data is present in the MLWH for eDAM to create the Legal agreement (DAA) using - But, it is up to them to check that there should be no releases to EGA without a legal agreement (DAA) in eDAM.

Who are the primary contacts for this story
@harrietc52

Who is the nominated tester for UAT
Odion A

Acceptance criteria
To be considered successful the solution must allow:

  • Give UAT MLWH RO credentials to eDAM devs for testing
  • Put a story in eDAMs dev cycle, requesting the ability for them to pull in data from MLWH UAT
  • Put a story in eDAMs dev cycle, requesting the ability for a study to be updated, after DAA is created and/or approved
  • Unified Warehouse is updated to add the new Study fields to the study table in the MLWH
  • On Study creation in SS, if the study contains the eDAM EGA fields (from Y24-419), add these fields to the MLWH study table
  • confirm the SQL query with Odion to enable eDAM to read the new fields added to the MLWH study table. (See current query used below)
  • eDAM confirms access to all Study data required to generate a DAA
  • eDAM only pulls in “standard” studies, whose data strategy is to be released in the EGA
  • testing with eDAM to confirm when a study is created, a DAA is created
  • testing with eDAM to confirm when a study is updated, an already created DAA is updated
  • testing with eDAM to confirm when a study is updated, an already created and approved DAA is updated

Dependencies
This story is blocked by the following dependencies:

References
This story has a non-blocking relationship with:

Additional context

Fields to be added:
PSD Google Sheet with DAA fields

Current query used in eDAM to pull MLWH study data:

SELECT id_study_lims, description, accession_number, study_title, faculty_sponsor 
FROM study 
WHERE data_release_strategy=‘managed’
;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LeGo Size: S Small - low effort & risk
Projects
None yet
Development

No branches or pull requests

1 participant