Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent removal of last character on no filename extension #120

Merged
merged 2 commits into from
Feb 3, 2023
Merged

fix: prevent removal of last character on no filename extension #120

merged 2 commits into from
Feb 3, 2023

Commits on Feb 1, 2023

  1. fix: prevent removal of last character on no filename extension 

    Fixes sanity-io/client#98

If a file is uploaded with an original filename that does not include an extension (`.png` or similar), the `getFilenameWithoutExtension` method will remove the last character of the filename, because it uses the last index of `.`, which is not found, resulting in `-1`.
    @rexxars
    rexxars authored Feb 1, 2023
    Configuration menu
    Copy the full SHA
    295eec3 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. fix: simplify filename inputs, trim before validation

    @robinpyon
    robinpyon committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    a50eb17 View commit details
    Browse the repository at this point in the history