From 9fcbc5c2db10e25d06722b8e0c2bce8d78c8a7b1 Mon Sep 17 00:00:00 2001 From: Per-Kristian Nordnes Date: Thu, 8 Sep 2022 15:18:30 +0200 Subject: [PATCH] fix(portable-text-editor): run empty check directly into decorate fn. --- .../@sanity/portable-text-editor/src/editor/Editable.tsx | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/packages/@sanity/portable-text-editor/src/editor/Editable.tsx b/packages/@sanity/portable-text-editor/src/editor/Editable.tsx index 1622d9bf80e..d64362fa210 100644 --- a/packages/@sanity/portable-text-editor/src/editor/Editable.tsx +++ b/packages/@sanity/portable-text-editor/src/editor/Editable.tsx @@ -322,13 +322,8 @@ export const PortableTextEditable = forwardRef(function PortableTextEditable( } }, [portableTextEditor, scrollSelectionIntoView]) - const isEmpty = useMemo( - () => isEqualToEmptyEditor(slateEditor.children, portableTextFeatures), - [portableTextFeatures, slateEditor.children] - ) - const decorate = useCallback(() => { - if (isEmpty) { + if (isEqualToEmptyEditor(slateEditor.children, portableTextFeatures)) { return [ { anchor: { @@ -344,7 +339,7 @@ export const PortableTextEditable = forwardRef(function PortableTextEditable( ] } return EMPTY_DECORATORS - }, [isEmpty]) + }, [portableTextFeatures, slateEditor.children]) // The editor const slateEditable = useMemo(