Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix numeric datasets being treated as missing #423

Merged
merged 1 commit into from
Dec 13, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,13 @@ export default {
description: 'Delete a dataset within your project',
action: async (args, context) => {
const {apiClient, prompt, output} = context
const [dataset] = args.argsWithoutOptions
if (!dataset) {
const [ds] = args.argsWithoutOptions
if (!ds) {
throw new Error('Dataset name must be provided')
}

const dataset = `${ds}`

await prompt.single({
type: 'input',
message: 'Are you ABSOLUTELY sure you want to delete this dataset?\n Type the name of the dataset to confirm delete:',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default {
const [targetDataset, targetDestination] = args.argsWithoutOptions
const {absolutify} = pathTools

let dataset = targetDataset
let dataset = targetDataset ? `${targetDataset}` : null
if (!dataset) {
dataset = await chooseDatasetPrompt(context, {message: 'Select dataset to export'})
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default {
const datasets = await client.datasets.list()
spinner.succeed('[100%] Fetching available datasets')

let targetDataset = target
let targetDataset = target ? `${target}` : null
if (!targetDataset) {
targetDataset = await chooseDatasetPrompt(context, {
message: 'Select target dataset',
Expand Down