From d2ca2ed3aa1fa91ea150f49408f472050dea5c9a Mon Sep 17 00:00:00 2001
From: Cody Olsen <stipsan@gmail.com>
Date: Thu, 2 Jan 2025 12:39:13 +0100
Subject: [PATCH] chore: fix typings

---
 packages/presentation/src/editor/ContentEditor.tsx         | 1 -
 packages/presentation/src/editor/usePreviewState.ts        | 1 -
 packages/presentation/src/overlays/schema/SchemaIcon.tsx   | 7 ++++++-
 packages/presentation/src/overlays/schema/extract.ts       | 3 ---
 .../src/overlay-components/components/InsertMenu.tsx       | 1 +
 5 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/packages/presentation/src/editor/ContentEditor.tsx b/packages/presentation/src/editor/ContentEditor.tsx
index 2252c32be..3552e055a 100644
--- a/packages/presentation/src/editor/ContentEditor.tsx
+++ b/packages/presentation/src/editor/ContentEditor.tsx
@@ -67,7 +67,6 @@ export function ContentEditor(props: {
     [mainDocumentState, schema],
   )
 
-  // @ts-expect-error fix later
   const previewState = usePreviewState(mainDocumentState?.document?._id || '', schemaType)
 
   const preview = useMemo(() => {
diff --git a/packages/presentation/src/editor/usePreviewState.ts b/packages/presentation/src/editor/usePreviewState.ts
index acd411a51..54b173a17 100644
--- a/packages/presentation/src/editor/usePreviewState.ts
+++ b/packages/presentation/src/editor/usePreviewState.ts
@@ -23,7 +23,6 @@ export default function usePreviewState(documentId: string, schemaType?: SchemaT
     }
     const subscription = getPreviewStateObservable(
       documentPreviewStore,
-      // @ts-expect-error fix later
       schemaType,
       documentId,
       '',
diff --git a/packages/presentation/src/overlays/schema/SchemaIcon.tsx b/packages/presentation/src/overlays/schema/SchemaIcon.tsx
index 210596309..0fbd4c3ce 100644
--- a/packages/presentation/src/overlays/schema/SchemaIcon.tsx
+++ b/packages/presentation/src/overlays/schema/SchemaIcon.tsx
@@ -14,7 +14,12 @@ export const SchemaIcon: FunctionComponent<{
   return Icon ? (
     <StyleSheetManager sheet={sheet.instance}>
       <ThemeProvider theme={theme} scheme={scheme} tone={tone}>
-        {isValidElement(Icon) ? Icon : <Icon />}
+        {isValidElement(Icon) ? (
+          Icon
+        ) : (
+          // @ts-expect-error -- @todo: fix typings
+          <Icon />
+        )}
       </ThemeProvider>
     </StyleSheetManager>
   ) : null
diff --git a/packages/presentation/src/overlays/schema/extract.ts b/packages/presentation/src/overlays/schema/extract.ts
index 4dd9efb3d..b64651227 100644
--- a/packages/presentation/src/overlays/schema/extract.ts
+++ b/packages/presentation/src/overlays/schema/extract.ts
@@ -207,7 +207,6 @@ export function extractSchema(workspace: Workspace, theme: ThemeContextValue): S
   const inlineFields = new Set<SanitySchemaType>()
   const {schema: schemaDef, basePath} = workspace
 
-  // @ts-expect-error fix later
   const sortedSchemaTypeNames = sortByDependencies(schemaDef)
   return sortedSchemaTypeNames
     .map((typeName) => {
@@ -215,7 +214,6 @@ export function extractSchema(workspace: Workspace, theme: ThemeContextValue): S
       if (schemaType === undefined) {
         return
       }
-      // @ts-expect-error fix later
       const base = convertBaseType(schemaType)
 
       if (base === null) {
@@ -223,7 +221,6 @@ export function extractSchema(workspace: Workspace, theme: ThemeContextValue): S
       }
 
       if (base.type === 'type') {
-        // @ts-expect-error fix later
         inlineFields.add(schemaType)
       }
 
diff --git a/packages/visual-editing/src/overlay-components/components/InsertMenu.tsx b/packages/visual-editing/src/overlay-components/components/InsertMenu.tsx
index 2396f2db9..a498f52ab 100644
--- a/packages/visual-editing/src/overlay-components/components/InsertMenu.tsx
+++ b/packages/visual-editing/src/overlay-components/components/InsertMenu.tsx
@@ -47,6 +47,7 @@ export const InsertMenu: FunctionComponent<InsertMenuProps> = (props) => {
         ...type,
         icon: getNodeIcon(type),
       }))}
+      // @ts-expect-error -- @todo fix typings
       onSelect={onSelect}
       views={views}
     />