Changing deprecated raven library to sentry-sdk library #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How could we test if the Image would work? |
JoJoPuppe
commented
Mar 7, 2025
There was a problem hiding this comment.
…h wrong SENTRY_DSN format
…tests - Added SentryFilterEngine for filtering Sentry events based on configurable rules. - Introduced RuleValidationError for handling rule validation errors. - Created load_rules_from_file function to load and validate rules from YAML configuration. - Developed unit tests for SentryFilterEngine and rule loader to ensure functionality and validation. - Updated Sentry WSGI middleware to integrate filtering engine and handle environment configurations. - Added example YAML configuration for Sentry filtering rules. - Updated requirements to use the latest version of sentry-sdk.
JoJoPuppe
force-pushed
the
sentry-library-change
branch
from
4cfdde2 to
e6451a2
Compare
|
I thought about the Problem more and came to the conclusion that SENTRY_EXCLUSIONS_LIST is not robust enough to handle different filter cases. Also there requirements came to my mind:
the new implementation features a FilterEngine for Sentry. this currently is based on the latest version of sentry-sdk and needs a new Sentry Deployment (23.6) to function correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry-sdk library can replace the deprecated raven library.
There is the option to use a Flask Integration or use the WSGI Integration.
The WSGI Integration is less intrusive.
To provide the necessary filtering a callback function can be declared that receives the exception event before it gets send to Sentry. here we can filter over a list of exception names that should be ignored.
env vars that should be provided:
SENTRY_EXCLUSIONS_LIST are the comma separated exception names.