Make user field optional in embedding request #899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Added
omitempty
json tag for theUser
field in theEmbeddingRequest
struct. This field is optional in embedding requests as per OpenAI spec.Issue: If you don't specify any user in the embedding request, the current spec sends the user as an empty string for which embedding models throw errors.
Provide OpenAI documentation link
https://platform.openai.com/docs/api-reference/embeddings/create#embeddings-create-user
Describe your solution
Added
omitempty
json tag for theUser
field in theEmbeddingRequest
struct. This will make theUser
field optional as per openai embeddings spec.Tests
Tested the above change by sending embeddings requests to the embeddings model with following payload: