This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Workaround the segfault that occurs when used with fsevents #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsevents@0.3.8 introduces a segfault that manifests when used with node-sass. fsevents is widely popular. As a mitigation we've added fsevents@0.3.7 as an optionalDependency.The intention here is the prevent users install node-sass@3.3.x and fsevents@0.3.8 by using npm's deduping behaviour.
xzyfer
added a commit
that referenced
this pull request
Aug 26, 2015
Workaround the segfault that occurs when used with fsevents
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsevents@0.3.8introduces a segfault that manifests when used with node-sass fsevents/fsevents#82fseventsis widely popular. As a mitigation we've addedfsevents@0.3.7as anoptionalDependency. The intention here is the prevent users installnode-sass@3.3.xandfsevents@0.3.8by using npm's deduping behaviour.Adding
optionalDependencywill cause npm to dedupe the package and install the most suitable version. Since we've pinned to a specific version ours will always be the most suitable.This is certainly cause us problems in the long run and should be reverted as soon as issue fixed upstream.