Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined: uuid.Must #69

Open
leffen opened this issue Jan 10, 2018 · 6 comments
Open

undefined: uuid.Must #69

leffen opened this issue Jan 10, 2018 · 6 comments

Comments

@leffen
Copy link

leffen commented Jan 10, 2018

Hi,

I am struggelig with dep and a dependency with this library. Unfortunately it seems like renstrom/shortuuid uses uuid.Must. Is it possible to get a release with this included so Dep can be satisfied ?

@ktnyt
Copy link

ktnyt commented Jan 10, 2018

Did you update your local copy of satori/uuid ? The master branch from this repository provides uuid.Must (which may or may not be reverted: refer to #66 ).

@leffen
Copy link
Author

leffen commented Jan 10, 2018

The problem for seems to be that the override to master in Gopkg.toml is overwritten by dep when doing the dep ensure -update and then its reverted back to the release. Probably due to another dependency.

@satori
Copy link
Owner

satori commented Jan 10, 2018

@leffen I've tagged v1.2.0 which is last commit before API has changed but contains some bug fixes and improvements including uuid.Must helper: https://github.com/satori/go.uuid/releases/tag/v1.2.0

I plan to make a few more changes over weekend / review some PRs and going to release v2.0.0 early next week.

@leffen
Copy link
Author

leffen commented Jan 10, 2018

Cool, Thanks. Looking forward to the new release :-)

@marcaudefroy
Copy link

Waiting the release, you can do this to force version for the transitive dependency :

[[override]]
name = "github.com/satori/go.uuid"
branch = "master"

More info on : https://github.com/golang/dep/blob/master/docs/FAQ.md#how-do-i-constrain-a-transitive-dependencys-version

kevinburke added a commit to kevinburke/go.uuid that referenced this issue Jan 25, 2018
This new function can support the desired feature (return error
instead of panic) without having to break compatibility for existing
clients.

Fixes satori#66.
Fixes satori#67.
Fixes satori#68.
Fixes satori#69.
Fixes satori#70.
@welps
Copy link

welps commented Feb 10, 2018

@satori No rush, any idea when the next release is going to get tagged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants