Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diktat should run tests using SAVE-engine #1059

Closed
orchestr7 opened this issue Sep 22, 2021 · 4 comments
Closed

Diktat should run tests using SAVE-engine #1059

orchestr7 opened this issue Sep 22, 2021 · 4 comments
Assignees
@Cheshiriks
Labels
enhancement New feature or request

Comments

@orchestr7
Copy link
Member

orchestr7 commented Sep 22, 2021 •
edited
Loading

We should rewrite our tests, so they would use save tests.
@orchestr7 orchestr7 added the enhancement New feature or request label Sep 22, 2021
@petertrr
Copy link
Member

petertrr commented Oct 5, 2021

Can it be considered done in #1060 ?

@Cheshiriks
Copy link
Member

Can it be considered done in #1060 ?

Not yet. Only one test is optimized for the fix and warn plugin.

@orchestr7
Copy link
Member Author

Main logic is done and checked in warnings mode. We are blocked by ktlint release by for now.

@Cheshiriks
Copy link
Member

completed in #1388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cheshiriks Cheshiriks

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petertrr @Cheshiriks @orchestr7