Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordering for 'zct-indentation' #1378

Closed
nulls opened this issue Jun 21, 2022 · 2 comments · Fixed by #1390
Closed

Ordering for 'zct-indentation' #1378

nulls opened this issue Jun 21, 2022 · 2 comments · Fixed by #1390
Assignees
@nulls
Labels
bug Something isn't working
Milestone
1.2.0

Comments

@nulls
Copy link
Member

nulls commented Jun 21, 2022

I tried, and this change can't be made at this time.

This does break the ordering, resulting in multiple test failures in org.cqfn.diktat.ruleset.smoke.DiktatSmokeTest.

Originally posted by @0x6675636b796f75676974687562 in #1376 (comment)
@nulls nulls self-assigned this Jun 21, 2022
@nulls nulls added the bug Something isn't working label Jun 21, 2022
@nulls nulls added this to the 1.2.0 milestone Jun 21, 2022
@nulls
Copy link
Member Author

nulls commented Jun 21, 2022

Also, needs to remove prefix for all rule id

@nulls
Copy link
Member Author

nulls commented Jun 22, 2022

closed by #1390

@nulls nulls closed this as completed Jun 22, 2022
@nulls nulls mentioned this issue Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nulls nulls

Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Fix ordering issue saveourtool/diktat
1 participant
@nulls