Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate diktat smoke tests to SAVE-cli mechanism #1383

Closed
orchestr7 opened this issue Jun 21, 2022 · 0 comments · Fixed by #1388
Closed

Migrate diktat smoke tests to SAVE-cli mechanism #1383

orchestr7 opened this issue Jun 21, 2022 · 0 comments · Fixed by #1388
Assignees
@Cheshiriks
Labels
bug Something isn't working

Comments

@orchestr7
Copy link
Member

  1. For diktat smoke tests you need to setup the logic for SAVE-cli.
    Use fix and warn plugin and run diktat with save-cli. Support only config files, wrapper will be created later.

  2. You should not break Unit testing of smoke tests - propose proper logic in Unit tests for removing these comments (matching SAVE-cli)
@orchestr7 orchestr7 added the bug Something isn't working label Jun 21, 2022
@Cheshiriks Cheshiriks changed the title Move diktat smoke tests to SAVE-cli Migrate diktat smoke tests to SAVE-cli mechanism Jun 21, 2022
Cheshiriks added a commit that referenced this issue Jun 21, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
3c2a4e4 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
@Cheshiriks Cheshiriks mentioned this issue Jun 21, 2022
Merged
Cheshiriks added a commit that referenced this issue Jun 22, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
d40ac6b 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jun 23, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
660a7d1 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jun 23, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
4e6f391 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jun 23, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
963c456 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jun 23, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
71a9fd4 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jun 28, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
f045ee9 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jun 29, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
345bbb4 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 4, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
e29f5d9 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 5, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
00628f7 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 5, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
e3e410e 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 5, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
33c5187 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 5, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
5e610f3 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 5, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
ac59eca 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 6, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
b3456af 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 6, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
98dc4a2 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 7, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
c9ee5f4 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
7f5184a 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
9f23ae5 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
289e135 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
abcdb8f 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
fa10731 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
3785fe8 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
f5127c0 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
ea5268c 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
80c375c 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
5ae5676 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
c1fb33a 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
5122d82 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
2464246 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 11, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
bb5a101 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 12, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
fe8f8eb 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 12, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
dd5e6be 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 12, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
4c8c223 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 12, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
ff780e4 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 14, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
91f3fd8 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 14, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
43a4de9 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 14, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
b6c3401 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 14, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
7fec3f3 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 14, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
04dc7ed 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 14, 2022
@Cheshiriks
Migrate diktat smoke tests to SAVE-cli mechanism
23ec13e 
### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383
Cheshiriks added a commit that referenced this issue Jul 15, 2022
@Cheshiriks @orchestr7
Migrate diktat smoke tests to SAVE-cli mechanism (#1388)
54c8cce 
* Migrate diktat smoke tests to SAVE-cli mechanism

### What's done:
* migrated diktat smoke tests to SAVE-cli mechanism
Closes #1383

Co-authored-by: Andrey Kuleshov <andrewkuleshov7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cheshiriks Cheshiriks

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate diktat smoke tests to SAVE-cli mechanism saveourtool/diktat
2 participants
@Cheshiriks @orchestr7