Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXTENSION_FUNCTION_WITH_CLASS false positive with external interfaces #1586

Closed
orchestr7 opened this issue Dec 9, 2022 · 0 comments · Fixed by #1630
Closed

EXTENSION_FUNCTION_WITH_CLASS false positive with external interfaces #1586

orchestr7 opened this issue Dec 9, 2022 · 0 comments · Fixed by #1630
Assignees
@0x6675636b796f75676974687562
Labels
bug Something isn't working
Milestone
1.2.5

Comments

@orchestr7
Copy link
Member

orchestr7 commented Dec 9, 2022 •
edited by 0x6675636b796f75676974687562
Loading 

external interface A: B {
}

fun A.extensionMethod() {}

In this example we are not able to move extensionMethod to interface
@orchestr7 orchestr7 added the bug Something isn't working label Dec 9, 2022
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 changed the title Extension function with class EXTENSION_FUNCTION_WITH_CLASS false positive with external interfaces Mar 17, 2023
0x6675636b796f75676974687562 added a commit that referenced this issue Mar 17, 2023
@0x6675636b796f75676974687562
Ignore external interfaces when triggering `EXTENSION_FUNCTION_WITH…
4d47318 
…_CLASS`

### What's done:

 - Fixes #1586
Merged
0x6675636b796f75676974687562 added a commit that referenced this issue Mar 17, 2023
@0x6675636b796f75676974687562
Ignore external interfaces when triggering `EXTENSION_FUNCTION_WITH…
fceabd5 
…_CLASS` (#1630)

### What's done:

 - Fixes #1586
@0x6675636b796f75676974687562 0x6675636b796f75676974687562 added this to the 1.2.5 milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x6675636b796f75676974687562 0x6675636b796f75676974687562

Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.5
Development

Successfully merging a pull request may close this issue.

Ignore external interfaces when triggering EXTENSION_FUNCTION_WITH_CLASS saveourtool/diktat
2 participants
@orchestr7 @0x6675636b796f75676974687562