Added Save in diktat smoke tests #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * added Save in diktat smoke tests Closes #1047
Cheshiriks
force-pushed
the
feature/run_tests_using_save
branch
from
24815f4
to
7bbb809
Compare
Codecov Report
@@ Coverage Diff @@
## master #1060 +/- ##
=========================================
Coverage 83.43% 83.43%
Complexity 2447 2447
=========================================
Files 102 102
Lines 6120 6120
Branches 1832 1832
=========================================
Hits 5106 5106
Misses 272 272
Partials 742 742
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
petertrr
reviewed
Sep 24, 2021
...st-framework/src/main/kotlin/org/cqfn/diktat/test/framework/processing/TestComparatorUnit.kt
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,10 @@ | |||
| [general] | |||
| execCmd="./ktlint -R diktat-1.0.0-rc.2.jar" | |||
There was a problem hiding this comment.
I thought we were planning to execute SAVE in CI too?
### What's done: * added Save in diktat smoke tests Closes #1047
petertrr
reviewed
Sep 24, 2021
| description = "SmokeTest" | ||
| suiteName = "SmokeTest" | ||
|
|
||
| [fix] |
There was a problem hiding this comment.
Shouldn't it be fix-and-warn? We have some unfixed warnings in smoke tests
### What's done: * added Save in diktat smoke tests Closes #1047
petertrr
approved these changes
Sep 29, 2021
| fun compareFilesFromResources( | ||
| expectedResult: String, | ||
| testFileStr: String, | ||
| smoke: Boolean = false): Boolean { |
There was a problem hiding this comment.
Suggested change
| smoke: Boolean = false): Boolean { | |
| trimLastEmptyLine: Boolean = false): Boolean { |
To make it look like a more general option
### What's done: * added Save in diktat smoke tests Closes #1047
petertrr
reviewed
Sep 29, 2021
Comment on lines
54
to
55
| val expectWithoutWarn = expect.filter { line -> | ||
| !line.contains(regex) |
There was a problem hiding this comment.
Suggested change
| val expectWithoutWarn = expect.filter { line -> | |
| !line.contains(regex) | |
| val expectWithoutWarn = expect.filterNot { line -> | |
| line.contains(regex) |
### What's done: * added Save in diktat smoke tests Closes #1047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: