Unsigned integer literal is perhaps incorrectly marked as a MAGIC_NUMBER #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertrr
approved these changes
Apr 28, 2022
### What's done: * fixed ignore number in MAGIC_NUMBER rule Closes #1224
### What's done: * fixed ignore number in MAGIC_NUMBER rule Closes #1224
### What's done: * fixed ignore number in MAGIC_NUMBER rule Closes #1224
### What's done: * fixed ignore number in MAGIC_NUMBER rule Closes #1224
### What's done: * fixed ignore number in MAGIC_NUMBER rule Closes #1224
orchestr7
approved these changes
Apr 28, 2022
orchestr7
reviewed
Apr 28, 2022
| @@ -108,7 +108,7 @@ class MagicNumberRule(configRules: List<RulesConfig>) : DiktatRule( | |||
| companion object { | |||
| const val IGNORE_TEST = true | |||
| const val NAME_ID = "aca-magic-number" | |||
| val ignoreNumbersList = listOf("-1", "1", "0", "2") | |||
| val ignoreNumbersList = listOf("-1", "1", "0", "2", "0U", "1U", "2U", "-1L", "0L", "1L", "2L", "0UL", "1UL", "2UL") | |||
There was a problem hiding this comment.
hope that we really compare strings in the logic
There was a problem hiding this comment.
I had to change the logic a bit
### What's done: * fixed ignore number in MAGIC_NUMBER rule Closes #1224
Codecov Report
@@ Coverage Diff @@
## master #1276 +/- ##
============================================
- Coverage 82.40% 82.37% -0.03%
Complexity 2550 2550
============================================
Files 105 105
Lines 7205 7207 +2
Branches 2018 2020 +2
============================================
Hits 5937 5937
Misses 351 351
- Partials 917 919 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kgevorkyan
reviewed
Apr 28, 2022
| @@ -102,13 +102,20 @@ class MagicNumberRule(configRules: List<RulesConfig>) : DiktatRule( | |||
| /** | |||
| * Check if string is number | |||
| */ | |||
| // || ((this.last().uppercase() == "L" || this.last().uppercase() == "U") && this.substring(0, this.lastIndex-1).isNumber()) | |||
There was a problem hiding this comment.
Probably we can finally improve our commented_out_code rule, to ignore leading whitespaces and make trigger on such cases 😐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Closes Unsigned integer literal is perhaps incorrectly marked as a MAGIC_NUMBER #1224