Set the default values of extendedIndentAfterOperators and extendedIndentBeforeDot to false
#1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nulls
reviewed
Jun 2, 2022
diktat-analysis.yml
Outdated
| @@ -226,7 +226,7 @@ | |||
| - name: LONG_LINE | |||
| enabled: true | |||
| configuration: | |||
| lineLength: '180' | |||
| lineLength: '181' | |||
There was a problem hiding this comment.
Because the increased indentation level (applied to our own codebase) results in longer lines, hence the need to increase the limit.
nulls
approved these changes
Jun 2, 2022
0x6675636b796f75676974687562
force-pushed
the
bugfix/andrey.shcheglov/extendedIndentOfParameters-should-be-true
branch
from
4aa8a86
to
319d8ab
Compare
0x6675636b796f75676974687562
changed the title
extendedIndentOfParameters back to trueextendedIndentAfterOperators and extendedIndentBeforeDot to false
|
Where are tests that you have promised? |
Yes, in this very PR. I'm working on those. |
…dIndentBeforeDot` to `false` ### What's done: * Since Kotlin style guide mentions no continuation indent, and IDEA defaults to no continuation indent as well, all `extendedIndent*` flags default to `false` from now on. * Closes: #1312
### What's done: * Reformatted the code so that it conforms to the new rules.
0x6675636b796f75676974687562
force-pushed
the
bugfix/andrey.shcheglov/extendedIndentOfParameters-should-be-true
branch
from
319d8ab
to
f0f6ef8
Compare
### What's done: * Unit tests adapted to the reformatted test resources. * Unit tests adapted to the new defaults.
Codecov Report
@@ Coverage Diff @@
## master #1342 +/- ##
============================================
+ Coverage 83.52% 83.56% +0.04%
- Complexity 2563 2564 +1
============================================
Files 106 106
Lines 7278 7278
Branches 2017 2017
============================================
+ Hits 6079 6082 +3
Misses 353 353
+ Partials 846 843 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0x6675636b796f75676974687562
deleted the
bugfix/andrey.shcheglov/extendedIndentOfParameters-should-be-true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
and IDEA defaults to no continuation indent as well,
all
extendedIndent*flags default tofalsefrom now on.WRONG_INDENTATION#1312Actions checklist