Migrate diktat smoke tests to SAVE-cli mechanism

[Cheshiriks]

What's done:

• migrated diktat smoke tests to SAVE-cli mechanism
  Closes Migrate diktat smoke tests to SAVE-cli mechanism #1383

[codecov]

Codecov Report

Merging #1388 (23ec13e) into master (7582190) will decrease coverage by 0.61%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1388      +/-   ##
============================================
- Coverage     83.23%   82.62%   -0.62%     
+ Complexity     2562     2542      -20     
============================================
  Files           107      104       -3     
  Lines          7619     7472     -147     
  Branches       2103     2086      -17     
============================================
- Hits           6342     6174     -168     
- Misses          388      435      +47     
+ Partials        889      863      -26     

Flag	Coverage Δ
unittests	82.62% <ø> (-0.62%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../kotlin/org/cqfn/diktat/plugin/maven/DiktatMojo.kt	9.09% <0.00%> (-81.82%)	⬇️
...lin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt	9.57% <0.00%> (-43.62%)	⬇️
...n/org/cqfn/diktat/plugin/gradle/DiktatExtension.kt
...rg/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7582190...23ec13e. Read the comment docs.

[github-actions]

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

1 300 tests   1 285 ✔️  2m 11s ⏱️
   159 suites       15 💤
   159 files           0 ❌

Results for commit 23ec13e.

♻️ This comment has been updated with latest results.

[github-actions]

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 286 tests   1 270 ✔️  49s ⏱️
   158 suites       16 💤
   158 files           0 ❌

Results for commit 23ec13e.

♻️ This comment has been updated with latest results.

[orchestr7]

Unit test for downloading of ktlint and putting diktat to a proper directory?

[orchestr7]

we need a unit test here

[petertrr]

@Cheshiriks please remove binaries from git, instead please either use an HTTP client in Java to download them before test or use maven plugin for downloading. Binaries should be placed in target directory so that they won't show up in Git and could be cleaned up by maven clean

[Cheshiriks]

@Cheshiriks please remove binaries from git, instead please either use an HTTP client in Java to download them before test or use maven plugin for downloading. Binaries should be placed in target directory so that they won't show up in Git and could be cleaned up by maven clean

Haven't we decided that for now we will just put the Save in the project, and later we will do the download of the file?

[petertrr]

@Cheshiriks please remove binaries from git, instead please either use an HTTP client in Java to download them before test or use maven plugin for downloading. Binaries should be placed in target directory so that they won't show up in Git and could be cleaned up by maven clean

Haven't we decided that for now we will just put the Save in the project, and later we will do the download of the file?

Having a 50MB file in git slows down every fetch operation :( We can add maven configuration later, but downloading from a JVM test seems to be easy enough to implement it right away

[Cheshiriks]

Please add TearDown and TearUp mechanism. No need to download everything and copy everything for thousand of times. Check how @petertrr does it in save-cli

Yes. Added

[petertrr]

Please move function definitions to more appropriate places, but overall lgtm