Fix ordering issue #1390
Fix ordering issue #1390
Conversation
nulls
force-pushed
the
bugfix/ordering-rule-id
branch
from
9c122cf
to
00def9f
Compare
diktat-rules/src/test/kotlin/org/cqfn/diktat/util/DiktatRuleSetProvider4Test.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/OrderedRuleSet.kt
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 13 potential problems in the proposed changes. Check the Files changed tab for more details.
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/rules/OrderedRuleSetTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Found 13 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 13 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 15 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 15 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 17 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 15 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 13 potential problems in the proposed changes. Check the Files changed tab for more details.
nulls
force-pushed
the
bugfix/ordering-rule-id
branch
from
cce8c7a
to
ac29a9e
Compare
There was a problem hiding this comment.
Found 15 potential problems in the proposed changes. Check the Files changed tab for more details.
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/rules/OrderedRuleSetTest.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/rules/OrderedRuleSetTest.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/rules/OrderedRuleSetTest.kt
Fixed
Show fixed
Hide fixed
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/rules/OrderedRuleSetTest.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## master #1390 +/- ##
============================================
- Coverage 83.30% 83.29% -0.02%
+ Complexity 2554 2552 -2
============================================
Files 107 107
Lines 7565 7571 +6
Branches 2090 2092 +2
============================================
+ Hits 6302 6306 +4
- Misses 373 374 +1
- Partials 890 891 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/rules/OrderedRuleSetTest.kt
Fixed
Show fixed
Hide fixed
- added ruleSetId to Rule.VisitorModifier.RunAfterRule - extracted ordering logic to OrderedRuleSet - removed all prefixes in rule_id
### What's done: - added ruleSetId to Rule.VisitorModifier.RunAfterRule - extracted ordering logic to OrderedRuleSet - removed all prefixes in rule_id
nulls
force-pushed
the
bugfix/ordering-rule-id
branch
from
ed94c43
to
f9d2bd9
Compare
What's done:
It closes #1378