Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle-plugin: Set user.home property if SARIF reporter is active #1426

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Jul 6, 2022

What's done:

  • Updated logic
  • Improved logging
  • Added tests

This pull request closes #1269

### What's done:
* Updated logic
* Improved logging
* Added tests
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #1426 (f2adc76) into master (00e0abf) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #1426      +/-   ##
============================================
- Coverage     83.37%   83.34%   -0.04%     
- Complexity     2561     2562       +1     
============================================
  Files           107      107              
  Lines          7604     7612       +8     
  Branches       2100     2103       +3     
============================================
+ Hits           6340     6344       +4     
- Misses          374      376       +2     
- Partials        890      892       +2     
Flag Coverage Δ
unittests 83.34% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 83.92% <50.00%> (-2.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e0abf...f2adc76. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

   159 files     159 suites   23m 37s ⏱️
1 281 tests 1 264 ✔️ 15 💤 2
1 283 runs  1 266 ✔️ 15 💤 2

For more details on these failures, see this check.

Results for commit 1343093.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

   159 files     159 suites   34m 24s ⏱️
1 281 tests 1 263 ✔️ 15 💤 3
1 284 runs  1 266 ✔️ 15 💤 3

For more details on these failures, see this check.

Results for commit 1343093.

@petertrr petertrr merged commit 0cd6d17 into master Jul 7, 2022
@petertrr petertrr deleted the bugfix/gradle-plugin#1269 branch July 7, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gradle-plugin: user.home for github actions is still incorrect
2 participants