Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMPTY_BLOCK_STRUCTURE_ERROR: is not raised on empty when block #1605

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

Cheshiriks
Copy link
Member

What's done:

  • added check for WHEN element

Closes #1539

### What's done:
* added check for WHEN element

Closes #1539
### What's done:
* added check for WHEN element

Closes #1539
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #1605 (847f4e5) into master (2da5f39) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1605   +/-   ##
=========================================
  Coverage     82.43%   82.44%           
  Complexity     2328     2328           
=========================================
  Files           112      112           
  Lines          7851     7854    +3     
  Branches       2037     2038    +1     
=========================================
+ Hits           6472     6475    +3     
  Misses          453      453           
  Partials        926      926           
Flag Coverage Δ
unittests 82.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 81.96% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

2 005 tests   - 3   1 989 ✔️  - 4   21m 17s ⏱️ -33s
   163 suites  - 2        15 💤 ±0 
   163 files    - 2          0 ±0   1 🔥 +1 

For more details on these errors, see this check.

Results for commit 847f4e5. ± Comparison against base commit 2da5f39.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   43m 19s ⏱️ + 7m 32s
1 990 tests +1  1 971 ✔️ +1  15 💤 ±0  4 ±0 
1 994 runs  +1  1 975 ✔️ +1  15 💤 ±0  4 ±0 

For more details on these failures, see this check.

Results for commit 847f4e5. ± Comparison against base commit 2da5f39.

♻️ This comment has been updated with latest results.

### What's done:
* added check for WHEN element

Closes #1539
@Cheshiriks Cheshiriks merged commit 98cdfaa into master Jan 31, 2023
@Cheshiriks Cheshiriks deleted the bugfix/when-element-node branch January 31, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EMPTY_BLOCK_STRUCTURE_ERROR: is not raised on empty when block
2 participants