Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend action functionality #44

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Conversation

ironashram
Copy link
Contributor

@ironashram ironashram commented Jan 27, 2024

Summary of changes

  • Add support for quay.io registry
  • Allow docker compose files to be anywhere in the repo

Does it keep it simple?

YES

Breaking Changes?

NO

How changes have been tested?, link to your runs

https://github.com/ironashram/mail-matrix-server/pull/3
https://github.com/ironashram/mail-matrix-server/actions/runs/7685036628/job/20942251854

Any unknowns or heads ups?

NO

add quay.io registry

Signed-off-by: Michele Palazzi <sysdadmin@m1k.cloud>
Signed-off-by: Michele Palazzi <sysdadmin@m1k.cloud>
Signed-off-by: Michele Palazzi <sysdadmin@m1k.cloud>
Signed-off-by: Michele Palazzi <sysdadmin@m1k.cloud>
@ironashram
Copy link
Contributor Author

@sbe-arg this seems working fine now, have a look if you're interested

@sbe-arg
Copy link
Owner

sbe-arg commented Jan 28, 2024

Not sure is about working fine is about why adding an unnecessary for loop to the logic.

Happy with the quay support part.

Signed-off-by: Michele Palazzi <sysdadmin@m1k.cloud>
@ironashram
Copy link
Contributor Author

Not sure is about working fine is about why adding an unnecessary for loop to the logic.

Happy with the quay support part.

removed the unnecessary loop while keeping the ability to have compose files anywhere

let me know if something else needs to be revised

Signed-off-by: Michele Palazzi <sysdadmin@m1k.cloud>
@sbe-arg
Copy link
Owner

sbe-arg commented Jan 29, 2024

@ironashram the last thing is if you can bump the VERSION file to v1.1.0 so we can auto release the action

Thanks for sorting the whitespace.

Signed-off-by: Michele Palazzi <sysdadmin@m1k.cloud>
Signed-off-by: Michele Palazzi <sysdadmin@m1k.cloud>
Signed-off-by: Michele Palazzi <sysdadmin@m1k.cloud>
@ironashram
Copy link
Contributor Author

@ironashram the last thing is if you can bump the VERSION file to v1.1.0 so we can auto release the action

Thanks for sorting the whitespace.

ok i did bump the version file, also fixed an issue with some quay images by increasing the pagination limit

@sbe-arg
Copy link
Owner

sbe-arg commented Jan 31, 2024

Awesome thanks, Ill merge soon.

@sbe-arg sbe-arg merged commit 3e2217b into sbe-arg:master Jan 31, 2024
2 checks passed
@ironashram ironashram deleted the extend_compose_find branch January 31, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants