Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'http headers' param in test-validation #13

Merged
merged 2 commits into from
Dec 1, 2015
Merged

fix 'http headers' param in test-validation #13

merged 2 commits into from
Dec 1, 2015

Conversation

ThomasLohner
Copy link

The param is actually called 'HTTP HEADERS' and not 'HOSTHEADER'.

see: https://mmonit.com/monit/documentation/monit.html

Syntax:

 PROTO(COL) HTTP
     [REQUEST "string"]
     [STATUS operator number]
     [CHECKSUM checksum]
     [HTTP HEADERS list of headers]
     [CONTENT {= | != } STRING]

@jonhattan
Copy link
Member

Ouch. This changed in monit 5.9 - see changelog https://mmonit.com/monit/changes/

We need to identify the monit version in use, and generate the config in concordance.

@jonhattan
Copy link
Member

Or, at least in this case, accept both params and add a comment indicating when HOSTHEADER was deprecated and HTTP HEADERS started being in force.

@ThomasLohner
Copy link
Author

thx for the feedback. i'll fix.

@ThomasLohner
Copy link
Author

I've added both Params and also provided a sample config for hiera in README.md

jonhattan added a commit that referenced this pull request Dec 1, 2015
fix 'http headers' param in test-validation
@jonhattan jonhattan merged commit a21e521 into sbitio:master Dec 1, 2015
@jonhattan
Copy link
Member

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants