From 461969b0057ebe7db6f2e1d055461a51833f2301 Mon Sep 17 00:00:00 2001
From: Josh Suereth <joshua.suereth@gmail.com>
Date: Wed, 10 Jul 2013 12:35:18 -0400
Subject: [PATCH 01/10] Add version to the default name of universal packages.

---
 .../typesafe/sbt/packager/universal/Keys.scala  |  4 +++-
 .../packager/universal/UniversalPlugin.scala    | 17 +++++++++++++++--
 src/sbt-test/universal/test-native-zip/test     |  2 +-
 src/sbt-test/universal/test-zips/test           |  6 +++---
 4 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/src/main/scala/com/typesafe/sbt/packager/universal/Keys.scala b/src/main/scala/com/typesafe/sbt/packager/universal/Keys.scala
index 9209edf1d..8f3a07382 100644
--- a/src/main/scala/com/typesafe/sbt/packager/universal/Keys.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/universal/Keys.scala
@@ -8,9 +8,9 @@ trait UniversalKeys {
   val packageZipTarball = TaskKey[File]("package-zip-tarball", "Creates a tgz package.")
   val packageXzTarball = TaskKey[File]("package-xz-tarball", "Creates a txz package.")
   val packageOsxDmg = TaskKey[File]("package-osx-dmg", "Creates a dmg package for OSX (only on osx).")
-  val stagingDirectory = SettingKey[File]("stagingDirectory", "The location where a staged distribution will be generated.")
   val stage = TaskKey[Unit]("stage", "Create a local directory with all the files laid out as they would be in the final distribution.")
   val dist = TaskKey[File]("dist", "Creates the distribution packages.")
+  val stagingDirectory = SettingKey[File]("stagingDirectory", "Directory where we stage distributions/releases.")
 }
 
 object Keys extends UniversalKeys {
@@ -21,4 +21,6 @@ object Keys extends UniversalKeys {
   def name = sbt.Keys.name
   def target = sbt.Keys.target
   def sourceDirectory = sbt.Keys.sourceDirectory
+  def streams = sbt.Keys.streams
+  def version = sbt.Keys.version
 }
\ No newline at end of file
diff --git a/src/main/scala/com/typesafe/sbt/packager/universal/UniversalPlugin.scala b/src/main/scala/com/typesafe/sbt/packager/universal/UniversalPlugin.scala
index ec667db4e..625a75bd7 100644
--- a/src/main/scala/com/typesafe/sbt/packager/universal/UniversalPlugin.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/universal/UniversalPlugin.scala
@@ -5,6 +5,7 @@ package universal
 import sbt._
 import Keys._
 import Archives._
+import sbt.Keys.TaskStreams
 
 /** Defines behavior to construct a 'universal' zip for installation. */
 trait UniversalPlugin extends Plugin {
@@ -14,6 +15,13 @@ trait UniversalPlugin extends Plugin {
   
   /** The basic settings for the various packaging types. */ 
   def universalSettings: Seq[Setting[_]] = 
+    Seq[Setting[_]](
+      // For now, we provide delegates from dist/stage to universal...
+      dist <<= dist in Universal,
+      stage <<= stage in Universal,
+      // TODO - New default to naming, is this right?
+      name in Universal <<= (name, version) apply (_ + "-" + _)
+    ) ++
     makePackageSettingsForConfig(Universal) ++
     makePackageSettingsForConfig(UniversalDocs) ++ 
     makePackageSettingsForConfig(UniversalSrc)
@@ -26,7 +34,7 @@ trait UniversalPlugin extends Plugin {
     makePackageSettings(packageXzTarball, config)(makeTxz) ++
     inConfig(config)(Seq(
       mappings <<= sourceDirectory map findSources,
-      dist <<= packageBin,
+      dist <<= (packageBin, streams) map printDist,
       stagingDirectory <<= target apply (_ / "stage"),
       stage <<= (stagingDirectory, mappings) map stageFiles
     )) ++ Seq(
@@ -39,7 +47,12 @@ trait UniversalPlugin extends Plugin {
     makePackageSettings(packageBin, UniversalDocs)(makeNativeZip) ++
     makePackageSettings(packageBin, UniversalSrc)(makeNativeZip)
     
-  
+  private[this] def printDist(dist: File, streams: TaskStreams): File = {
+    streams.log.info("")
+    streams.log.info("Your package is ready in " + dist.getCanonicalPath)
+    streams.log.info("")
+    dist
+  }
     
   private[this] def stageFiles(to: File, mappings: Seq[(File, String)]): Unit = {
     val copies = mappings collect { case (f, p) => f -> (to / p) }
diff --git a/src/sbt-test/universal/test-native-zip/test b/src/sbt-test/universal/test-native-zip/test
index c2fda0ebe..d3f226f48 100644
--- a/src/sbt-test/universal/test-native-zip/test
+++ b/src/sbt-test/universal/test-native-zip/test
@@ -1,5 +1,5 @@
 # Run the zip packaging.
 > show universal:package-bin
-$ exists target/universal/simple-test.zip
+$ exists target/universal/simple-test-0.1.0.zip
 
 # TODO - Check contents of zips.  Ensure file permissions are preserved.
diff --git a/src/sbt-test/universal/test-zips/test b/src/sbt-test/universal/test-zips/test
index fdfa4346f..72fdb39de 100644
--- a/src/sbt-test/universal/test-zips/test
+++ b/src/sbt-test/universal/test-zips/test
@@ -1,14 +1,14 @@
 # Run the zip packaging.
 > show universal:package-bin
-$ exists target/universal/simple-test.zip
+$ exists target/universal/simple-test-0.1.0.zip
 
 # Run the tgz packaging.
 > universal:package-zip-tarball
-$ exists target/universal/simple-test.tgz
+$ exists target/universal/simple-test-0.1.0.tgz
 
 # Run the txz packaging.
 > universal:package-xz-tarball
-$ exists target/universal/simple-test.txz
+$ exists target/universal/simple-test-0.1.0.txz
 
 
 # TODO - Check contents of zips

From 5a72fd2bc47ddc4c3961f1d8798435c129edb087 Mon Sep 17 00:00:00 2001
From: Josh Suereth <joshua.suereth@gmail.com>
Date: Wed, 10 Jul 2013 12:42:12 -0400
Subject: [PATCH 02/10] Add test for gneeric mappings.

---
 src/sbt-test/debian/test-mapping/build.sbt    | 20 +++++++++++++++++++
 .../debian/test-mapping/project/plugins.sbt   |  1 +
 .../debian/test-mapping/src/debian/changelog  | 12 +++++++++++
 .../src/linux/usr/share/man/man1/test.1       |  6 ++++++
 .../test-mapping/src/universal/bin/test       |  0
 src/sbt-test/debian/test-mapping/test         |  6 ++++++
 6 files changed, 45 insertions(+)
 create mode 100644 src/sbt-test/debian/test-mapping/build.sbt
 create mode 100644 src/sbt-test/debian/test-mapping/project/plugins.sbt
 create mode 100644 src/sbt-test/debian/test-mapping/src/debian/changelog
 create mode 100644 src/sbt-test/debian/test-mapping/src/linux/usr/share/man/man1/test.1
 create mode 100755 src/sbt-test/debian/test-mapping/src/universal/bin/test
 create mode 100644 src/sbt-test/debian/test-mapping/test

diff --git a/src/sbt-test/debian/test-mapping/build.sbt b/src/sbt-test/debian/test-mapping/build.sbt
new file mode 100644
index 000000000..a856482cd
--- /dev/null
+++ b/src/sbt-test/debian/test-mapping/build.sbt
@@ -0,0 +1,20 @@
+import NativePackagerKeys._
+
+packagerSettings
+
+mapGenericFilesToLinux
+
+name := "debian-test"
+
+version := "0.1.0"
+
+maintainer := "Josh Suereth <joshua.suereth@typesafe.com>"
+
+packageSummary := "Test debian package"
+
+packageDescription := """A fun package description of our software,
+  with multiple lines."""
+
+debianPackageDependencies in Debian ++= Seq("java2-runtime", "bash (>= 2.05a-11)")
+
+debianPackageRecommends in Debian += "git"
diff --git a/src/sbt-test/debian/test-mapping/project/plugins.sbt b/src/sbt-test/debian/test-mapping/project/plugins.sbt
new file mode 100644
index 000000000..b53de154c
--- /dev/null
+++ b/src/sbt-test/debian/test-mapping/project/plugins.sbt
@@ -0,0 +1 @@
+addSbtPlugin("com.typesafe.sbt" % "sbt-native-packager" % sys.props("project.version"))
diff --git a/src/sbt-test/debian/test-mapping/src/debian/changelog b/src/sbt-test/debian/test-mapping/src/debian/changelog
new file mode 100644
index 000000000..ec30582fa
--- /dev/null
+++ b/src/sbt-test/debian/test-mapping/src/debian/changelog
@@ -0,0 +1,12 @@
+
+sbt (0.12.0-build-0100)
+
+  * No need for different launcher jar files now
+
+ -- Joshua Suereth <joshua.suereth@typesafe.com>  2012-07-2012
+ 
+sbt (0.11.2-build-0100)
+
+  * First debian package release
+
+ -- Joshua Suereth <joshua.suereth@typesafe.com>  2011-11-29
diff --git a/src/sbt-test/debian/test-mapping/src/linux/usr/share/man/man1/test.1 b/src/sbt-test/debian/test-mapping/src/linux/usr/share/man/man1/test.1
new file mode 100644
index 000000000..0eb351c37
--- /dev/null
+++ b/src/sbt-test/debian/test-mapping/src/linux/usr/share/man/man1/test.1
@@ -0,0 +1,6 @@
+.\" Process this file with
+.\" groff -man -Tascii sbt.1
+.\"
+.TH TEST 1 "NOVEMBER 2013" Linux "User Manuals"
+.SH NAME
+test \- TEST
diff --git a/src/sbt-test/debian/test-mapping/src/universal/bin/test b/src/sbt-test/debian/test-mapping/src/universal/bin/test
new file mode 100755
index 000000000..e69de29bb
diff --git a/src/sbt-test/debian/test-mapping/test b/src/sbt-test/debian/test-mapping/test
new file mode 100644
index 000000000..edb38a825
--- /dev/null
+++ b/src/sbt-test/debian/test-mapping/test
@@ -0,0 +1,6 @@
+# Run the debian packaging.
+> debian:package-bin
+$ exists target/debian-test-0.1.0.deb
+
+
+# TODO - Test that the generic mapping did the right thing.

From 69c3bd5b53b6a7a3e7ecbd4b02e5248be917d040 Mon Sep 17 00:00:00 2001
From: Josh Suereth <joshua.suereth@gmail.com>
Date: Wed, 10 Jul 2013 13:54:09 -0400
Subject: [PATCH 03/10] Adding `makeBashScript` key and tests.

* Add `makeBashScript` key to global Keys.
* Update JavaAppbashScript to use `makeBashScript` key.
* Move BASH script itself into resources as a template file.
* Update Java app archetype to be friendlier
* Add new test for non-prefixed `stage` and `dist` tasks
* Adding test to ensure autogenerated bash script works.
---
 .../sbt/packager/archetypes/bash-template     | 285 ++++++++++++++++++
 .../com/typesafe/sbt/PackagerPlugin.scala     |   3 +-
 .../com/typesafe/sbt/packager/Keys.scala      |  10 +-
 .../sbt/packager/archetypes/JavaApp.scala     |  50 +--
 .../archetypes/JavaAppBashScript.scala        | 224 +-------------
 .../packager/universal/UniversalPlugin.scala  |   2 +
 .../debian/java-app-archetype/build.sbt       |  32 ++
 .../java-app-archetype/project/plugins.sbt    |   1 +
 .../src/main/scala/test/Test.scala            |   5 +
 src/sbt-test/debian/java-app-archetype/test   |   6 +
 src/sbt-test/universal/dist/build.sbt         |   7 +
 .../universal/dist/project/plugins.sbt        |   1 +
 .../universal/dist/src/universal/conf/test    |   1 +
 src/sbt-test/universal/dist/test              |   3 +
 14 files changed, 382 insertions(+), 248 deletions(-)
 create mode 100644 src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template
 create mode 100644 src/sbt-test/debian/java-app-archetype/build.sbt
 create mode 100644 src/sbt-test/debian/java-app-archetype/project/plugins.sbt
 create mode 100644 src/sbt-test/debian/java-app-archetype/src/main/scala/test/Test.scala
 create mode 100644 src/sbt-test/debian/java-app-archetype/test
 create mode 100644 src/sbt-test/universal/dist/build.sbt
 create mode 100644 src/sbt-test/universal/dist/project/plugins.sbt
 create mode 100644 src/sbt-test/universal/dist/src/universal/conf/test
 create mode 100644 src/sbt-test/universal/dist/test

diff --git a/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template b/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template
new file mode 100644
index 000000000..a74fe5d2a
--- /dev/null
+++ b/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template
@@ -0,0 +1,285 @@
+#!/bin/bash
+
+###  ------------------------------- ###
+###  Helper methods for BASH scripts ###
+###  ------------------------------- ###
+
+realpath () {
+(
+  TARGET_FILE="$1"
+
+  cd $(dirname "$TARGET_FILE")
+  TARGET_FILE=$(basename "$TARGET_FILE")
+
+  COUNT=0
+  while [ -L "$TARGET_FILE" -a $COUNT -lt 100 ]
+  do
+      TARGET_FILE=$(readlink "$TARGET_FILE")
+      cd $(dirname "$TARGET_FILE")
+      TARGET_FILE=$(basename "$TARGET_FILE")
+      COUNT=$(($COUNT + 1))
+  done
+
+  # make sure we grab the actual windows path, instead of cygwin's path.
+  echo $(cygwinpath "$(pwd -P)/$TARGET_FILE")
+)
+}
+
+# TODO - Do we need to detect msys?
+
+# Uses uname to detect if we're in the odd cygwin environment.
+is_cygwin() {
+  local os=$(uname -s)
+  case "$os" in
+    CYGWIN*) return 0 ;;
+    *)  return 1 ;;
+  esac
+}
+
+# This can fix cygwin style /cygdrive paths so we get the
+# windows style paths.
+cygwinpath() {
+  local file="$1"
+  if is_cygwin; then
+    echo $(cygpath -w $file)
+  else
+    echo $file
+  fi
+}
+
+# Make something URI friendly
+make_url() {
+  url="$1"
+  local nospaces=${url// /%20}
+  if is_cygwin; then
+    echo "/${nospaces//\\//}"
+  else
+    echo "$nospaces"
+  fi
+}
+
+# Detect if we should use JAVA_HOME or just try PATH.
+get_java_cmd() {
+  if [[ -n "$JAVA_HOME" ]] && [[ -x "$JAVA_HOME/bin/java" ]];  then
+    echo "$JAVA_HOME/bin/java"
+  else
+    echo "java"
+  fi
+}
+
+echoerr () {
+  echo 1>&2 "$@"
+}
+vlog () {
+  [[ $verbose || $debug ]] && echoerr "$@"
+}
+dlog () {
+  [[ $debug ]] && echoerr "$@"
+}
+execRunner () {
+  # print the arguments one to a line, quoting any containing spaces
+  [[ $verbose || $debug ]] && echo "# Executing command line:" && {
+    for arg; do
+      if printf "%s\n" "$arg" | grep -q ' '; then
+        printf "\"%s\"\n" "$arg"
+      else
+        printf "%s\n" "$arg"
+      fi
+    done
+    echo ""
+  }
+
+  exec "$@"
+}
+addJava () {
+  dlog "[addJava] arg = '$1'"
+  java_args=( "${java_args[@]}" "$1" )
+}
+addApp () {
+  dlog "[addApp] arg = '$1'"
+  sbt_commands=( "${app_commands[@]}" "$1" )
+}
+addResidual () {
+  dlog "[residual] arg = '$1'"
+  residual_args=( "${residual_args[@]}" "$1" )
+}
+addDebugger () {
+  addJava "-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=$1"
+}
+# a ham-fisted attempt to move some memory settings in concert
+# so they need not be messed around with individually.
+get_mem_opts () {
+  local mem=${1:-1024}
+  local perm=$(( $mem / 4 ))
+  (( $perm > 256 )) || perm=256
+  (( $perm < 1024 )) || perm=1024
+  local codecache=$(( $perm / 2 ))
+
+  echo "-Xms${mem}m -Xmx${mem}m -XX:MaxPermSize=${perm}m -XX:ReservedCodeCacheSize=${codecache}m"
+}
+require_arg () {
+  local type="$1"
+  local opt="$2"
+  local arg="$3"
+  if [[ -z "$arg" ]] || [[ "${arg:0:1}" == "-" ]]; then
+    die "$opt requires <$type> argument"
+  fi
+}
+require_arg () {
+  local type="$1"
+  local opt="$2"
+  local arg="$3"
+  if [[ -z "$arg" ]] || [[ "${arg:0:1}" == "-" ]]; then
+    die "$opt requires <$type> argument"
+  fi
+}
+is_function_defined() {
+  declare -f "$1" > /dev/null
+}
+
+# If we're *not* running in a terminal, and we don't have any arguments, then we need to add the 'ui' parameter
+detect_terminal_for_ui() {
+  [[ ! -t 0 ]] && [[ "${#residual_args}" == "0" ]] && {
+    addResidual "ui"
+  }
+  # SPECIAL TEST FOR MAC
+  [[ "$(uname)" == "Darwin" ]] && [[ "$HOME" == "$PWD" ]] && [[ "${#residual_args}" == "0" ]] && {
+    echo "Detected MAC OSX launched script...."
+    echo "Swapping to UI"
+    addResidual "ui"
+  }
+}
+
+# Processes incoming arguments and places them in appropriate global variables.  called by the run method.
+process_args () {
+  while [[ $# -gt 0 ]]; do
+    case "$1" in
+       -h|-help) usage; exit 1 ;;
+    -v|-verbose) verbose=1 && shift ;;
+      -d|-debug) debug=1 && shift ;;
+
+           -mem) require_arg integer "$1" "$2" && app_mem="$2" && shift 2 ;;
+     -jvm-debug) require_arg port "$1" "$2" && addDebugger $2 && shift 2 ;;
+
+     -java-home) require_arg path "$1" "$2" && java_cmd="$2/bin/java" && shift 2 ;;
+
+            -D*) addJava "$1" && shift ;;
+            -J*) addJava "${1:2}" && shift ;;
+              *) addResidual "$1" && shift ;;
+    esac
+  done
+
+  is_function_defined process_my_args && {
+    myargs=("${residual_args[@]}")
+    residual_args=()
+    process_my_args "${myargs[@]}"
+  }
+}
+
+# Actually runs the script.
+run() {
+  # TODO - check for sane environment
+
+  # process the combined args, then reset "$@" to the residuals
+  process_args "$@"
+  detect_terminal_for_ui
+  set -- "${residual_args[@]}"
+  argumentCount=$#
+
+  #check for jline terminal fixes on cygwin
+  if is_cygwin; then
+    stty -icanon min 1 -echo > /dev/null 2>&1
+    addJava "-Djline.terminal=jline.UnixTerminal"
+    addJava "-Dsbt.cygwin=true"
+  fi
+  # run sbt
+  execRunner "$java_cmd" \
+    $(get_mem_opts $app_mem) \
+    ${java_opts} \
+    ${java_args[@]} \
+    -cp "$app_classpath" \
+    $app_mainclass \
+    "${app_commands[@]}" \
+    "${residual_args[@]}"
+    
+  local exit_code=$?
+  if is_cygwin; then
+    stty icanon echo > /dev/null 2>&1
+  fi
+  exit $exit_code
+}
+
+# Loads a configuration file full of default command line options for this script.
+loadConfigFile() {
+  cat "$1" | sed '/^\#/d'
+}
+
+###  ------------------------------- ###
+###  Start of customized settings    ###
+###  ------------------------------- ###
+usage() {
+ cat <<EOM
+Usage: $script_name [ui] [options]
+
+  ui                 starts the Activator UI
+  new                Create a new project from a template
+  -h | -help         print this message
+  -v | -verbose      this runner is chattier
+  -d | -debug        set sbt log level to debug
+  -mem    <integer>  set memory options (default: $sbt_mem, which is $(get_mem_opts $sbt_mem))
+  -jvm-debug <port>  Turn on JVM debugging, open at the given port.
+
+  # java version (default: java from PATH, currently $(java -version 2>&1 | grep version))
+  -java-home <path>         alternate JAVA_HOME
+
+  # jvm options and output control
+  JAVA_OPTS          environment variable, if unset uses "$java_opts"
+  -Dkey=val          pass -Dkey=val directly to the java runtime
+  -J-X               pass option -X directly to the java runtime
+                     (-J is stripped)
+
+In the case of duplicated or conflicting options, the order above
+shows precedence: JAVA_OPTS lowest, command line options highest.
+EOM
+}
+
+###  ------------------------------- ###
+###  Main script                     ###
+###  ------------------------------- ###
+
+declare -a residual_args
+declare -a java_args
+declare -a app_commands
+declare -r app_home="$(realpath "$(dirname "$0")")"
+${{template_declares}}
+declare -r java_cmd=$(get_java_cmd)
+# TODO - Check whether this is ok in cygwin...
+declare -r lib_dir="${app_home}/../lib"
+declare -r app_classpath="$lib_dir/*"
+
+# Now check to see if it's a good enough version
+# TODO - Check to see if we have a configured default java version, otherwise use 1.6
+declare -r java_version=$("$java_cmd" -version 2>&1 | awk -F '"' '/version/ {print $2}')
+if [[ "$java_version" == "" ]]; then
+  echo
+  echo No java installations was detected.
+  echo Please go to http://www.java.com/getjava/ and download
+  echo
+  exit 1
+elif [[ ! "$java_version" > "1.6" ]]; then
+  echo
+  echo The java installation you have is not up to date
+  echo $app_name requires at least version 1.6+, you have
+  echo version $java_version
+  echo
+  echo Please go to http://www.java.com/getjava/ and download
+  echo a valid Java Runtime and install before running $app_name.
+  echo
+  exit 1
+fi
+
+
+# if configuration files exist, prepend their contents to $@ so it can be processed by this runner
+[[ -f "$script_conf_file" ]] && set -- $(loadConfigFile "$script_conf_file") "$@"
+
+run "$@"
\ No newline at end of file
diff --git a/src/main/scala/com/typesafe/sbt/PackagerPlugin.scala b/src/main/scala/com/typesafe/sbt/PackagerPlugin.scala
index 317d739d7..ef13e10a8 100644
--- a/src/main/scala/com/typesafe/sbt/PackagerPlugin.scala
+++ b/src/main/scala/com/typesafe/sbt/PackagerPlugin.scala
@@ -41,8 +41,9 @@ object SbtNativePackager extends Plugin
                            addPackage(UniversalDocs, packageXzTarball in UniversalDocs, "txz")
   
   object packageArchetype {
+    private[this] def genericMappingSettings: Seq[Setting[_]] = packagerSettings ++ mapGenericFilesToLinux ++ mapGenericFilesToWindows
     def java_application: Seq[Setting[_]] = 
-      packagerSettings ++ archetypes.JavaAppPackaging.settings
+      genericMappingSettings ++ archetypes.JavaAppPackaging.settings
   }
                            
   // TODO - Add a few targets that detect the current OS and build a package for that OS.
diff --git a/src/main/scala/com/typesafe/sbt/packager/Keys.scala b/src/main/scala/com/typesafe/sbt/packager/Keys.scala
index ab76a811d..05fabc1f6 100644
--- a/src/main/scala/com/typesafe/sbt/packager/Keys.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/Keys.scala
@@ -1,8 +1,16 @@
 package com.typesafe.sbt
 package packager
 
+import sbt._
+
 object Keys extends linux.Keys 
   with debian.DebianKeys 
   with rpm.RpmKeys 
   with windows.WindowsKeys
-  with universal.UniversalKeys {}
\ No newline at end of file
+  with universal.UniversalKeys {
+  
+  // TODO - Do these keys belong here?
+  val makeBashScript = TaskKey[Option[File]]("makeBashScript", "Creates or discovers the bash script used by this project.")
+  val makeBinScript = TaskKey[File]("makeBashScript", "Creates or discovers the binscript used by this project.")
+  
+}
\ No newline at end of file
diff --git a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
index 34998b2cd..ca97fce58 100644
--- a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
@@ -18,25 +18,27 @@ import SbtNativePackager._
  */
 object JavaAppPackaging {
   
-  def settings =
-    defaultUniversalSettings ++
-    defaultLinuxSettings
-    
-  /// Universal packaging defaults.
-  def defaultUniversalSettings: Seq[Setting[_]] = Seq(
+  def settings: Seq[Setting[_]] = Seq(
     mappings in Universal <++= (Keys.managedClasspath in Compile) map universalDepMappings,
     mappings in Universal <+= (Keys.packageBin in Compile) map { jar =>
       jar -> ("lib/" + jar.getName)
     },
-    mappings in Universal <++= (Keys.mainClass in Compile, target in Universal, name in Universal) map makeUniversalBinScript 
+    makeBashScript <<= (Keys.mainClass in Compile, target in Universal, name in Universal) map makeUniversalBinScript,
+    mappings in Universal <++= (makeBashScript, name) map { (script, name) =>
+      for {
+        s <- script.toSeq  
+      } yield s -> ("bin/" + name)
+    } 
   )
   
-  def makeUniversalBinScript(mainClass: Option[String], tmpDir: File, name: String): Seq[(File, String)] = 
-    for(mc <- mainClass.toSeq) yield {
+  def makeUniversalBinScript(mainClass: Option[String], tmpDir: File, name: String): Option[File] = 
+    for(mc <- mainClass) yield {
       val scriptBits = JavaAppBashScript.generateScript(mc)
       val script = tmpDir / "tmp" / "bin" / name
       IO.write(script, scriptBits)
-      script -> ("bin/" + name)
+      // TODO - Better control over this!
+      script.setExecutable(true)
+      script
     }
   
   // Converts a managed classpath into a set of lib mappings.
@@ -47,32 +49,4 @@ object JavaAppPackaging {
       // TODO - Figure out what to do with jar files.
       if file.isFile
     } yield dep.data -> ("lib/" + dep.data.getName)
-    
-    
-  // Default linux settings are driven off of the universal settings.  
-  def defaultLinuxSettings: Seq[Setting[_]] = Seq(
-    linuxPackageMappings <+= (mappings in Universal, name in Linux) map filterLibs,
-    linuxPackageMappings <++= (mainClass in Compile, name in Linux, target in Linux) map makeLinuxBinScrit
-  )
-  
-  def filterLibs(mappings: Seq[(File, String)], name: String): LinuxPackageMapping = {
-    val libs = for {
-      (file, location) <- mappings
-      if location startsWith "lib/"
-    } yield file -> ("/usr/share/"+name+"/" + location)
-    packageMapping(libs:_*)
-  }
-  
-    
-  def makeLinuxBinScrit(mainClass: Option[String], name: String, tmpDir: File): Seq[LinuxPackageMapping] =
-    for(mc <- mainClass.toSeq) yield {
-      val scriptBits = JavaAppBashScript.generateScript(
-          mainClass = mc,
-          libDir = "/usr/share/" + name + "/lib")
-      val script = tmpDir / "tmp" / "bin" / name
-      IO.write(script, scriptBits)
-      val scriptMapping = script -> ("/usr/bin/" + name)
-      
-      packageMapping(scriptMapping).withPerms("0755")
-    }
 }
\ No newline at end of file
diff --git a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBashScript.scala b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBashScript.scala
index 344ad2254..cf199806e 100644
--- a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBashScript.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBashScript.scala
@@ -2,22 +2,27 @@ package com.typesafe.sbt.packager.archetypes
 
 object JavaAppBashScript {
   
+  private[this] def bashTemplateSource =
+    getClass.getResource("bash-template")
+  private[this] def charset =
+    java.nio.charset.Charset.forName("UTF-8")
   def generateScript(mainClass: String,
-                     libDir: String = "$(dirname $(realpath $0))/../lib",
                      configFile: Option[String] = None): String = {
-    val sb = new StringBuffer
-    sb append template_header
-    sb append mainClassDefine(mainClass)
-    sb append defaultUsage
-    configFile foreach (f => sb append configFileDefine(f))
-    sb append defineLibLocation(libDir)
-    sb append template_footer
+     val sb = new StringBuffer
+     val defines: Seq[String] =
+       (configFile map configFileDefine).toSeq ++
+       Seq(mainClassDefine(mainClass))
+     for(line <- sbt.IO.readLinesURL(bashTemplateSource, charset)) {
+       if(line contains """${{template_declares}}""") {
+         sb append (defines mkString "\n")
+       } else {
+         sb append line
+         sb append "\n"
+       }
+     }
     sb.toString
   }
   
-  def defineLibLocation(libDir: String) =
-    "declare -r lib_dir=%s" format (libDir)
-
   def configFileDefine(configFile: String) =
     "declare -r script_conf_file=\"%s\"" format (configFile)
   
@@ -25,201 +30,4 @@ object JavaAppBashScript {
     "declare -r app_mainclass=\"%s\"\n" format (mainClass)
   
   
-  val defaultUsage = """usage() {
- cat <<EOM
-Usage: $script_name [options]
-
-  -h | -help         print this message
-  -v | -verbose      this runner is chattier
-  -d | -debug        set sbt log level to debug
-  -mem    <integer>  set memory options (default: $sbt_mem, which is $(get_mem_opts $sbt_mem))
-  -jvm-debug <port>  Turn on JVM debugging, open at the given port.
-
-  # java version (default: java from PATH, currently $(java -version 2>&1 | grep version))
-  -java-home <path>         alternate JAVA_HOME
-
-  # jvm options and output control
-  JAVA_OPTS          environment variable, if unset uses "$java_opts"
-  -Dkey=val          pass -Dkey=val directly to the java runtime
-  -J-X               pass option -X directly to the java runtime 
-                     (-J is stripped)
-
-In the case of duplicated or conflicting options, the order above
-shows precedence: JAVA_OPTS lowest, command line options highest.
-EOM
-}
-"""
-  
-  
-  
-  val template_header = """#!/bin/bash
-
-###  ------------------------------- ###
-###  Helper methods for BASH scripts ###
-###  ------------------------------- ###
-
-realpath () {
-(
-  TARGET_FILE=$1
-
-  cd $(dirname $TARGET_FILE)
-  TARGET_FILE=$(basename $TARGET_FILE)
-
-  COUNT=0
-  while [ -L "$TARGET_FILE" -a $COUNT -lt 100 ]
-  do
-      TARGET_FILE=$(readlink $TARGET_FILE)
-      cd $(dirname $TARGET_FILE)
-      TARGET_FILE=$(basename $TARGET_FILE)
-      COUNT=$(($COUNT + 1))
-  done
-
-  echo $(pwd -P)/$TARGET_FILE
-)
-}
-echoerr () {
-  echo 1>&2 "$@"
-}
-vlog () {
-  [[ $verbose || $debug ]] && echoerr "$@"
-}
-dlog () {
-  [[ $debug ]] && echoerr "$@"
-}
-execRunner () {
-  # print the arguments one to a line, quoting any containing spaces
-  [[ $verbose || $debug ]] && echo "# Executing command line:" && {
-    for arg; do
-      if printf "%s\n" "$arg" | grep -q ' '; then
-        printf "\"%s\"\n" "$arg"
-      else
-        printf "%s\n" "$arg"
-      fi
-    done
-    echo ""
-  }
-
-  exec "$@"
-}
-addJava () {
-  dlog "[addJava] arg = '$1'"
-  java_args=( "${java_args[@]}" "$1" )
-}
-addApp () {
-  dlog "[addApp] arg = '$1'"
-  sbt_commands=( "${app_commands[@]}" "$1" )
-}
-addResidual () {
-  dlog "[residual] arg = '$1'"
-  residual_args=( "${residual_args[@]}" "$1" )
-}
-addDebugger () {
-  addJava "-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=$1"
-}
-# a ham-fisted attempt to move some memory settings in concert
-# so they need not be dicked around with individually.
-get_mem_opts () {
-  local mem=${1:-1536}
-  local perm=$(( $mem / 4 ))
-  (( $perm > 256 )) || perm=256
-  (( $perm < 1024 )) || perm=1024
-  local codecache=$(( $perm / 2 ))
-
-  echo "-Xms${mem}m -Xmx${mem}m -XX:MaxPermSize=${perm}m -XX:ReservedCodeCacheSize=${codecache}m"
-}
-require_arg () {
-  local type="$1"
-  local opt="$2"
-  local arg="$3"
-  if [[ -z "$arg" ]] || [[ "${arg:0:1}" == "-" ]]; then
-    die "$opt requires <$type> argument"
-  fi
-}
-require_arg () {
-  local type="$1"
-  local opt="$2"
-  local arg="$3"
-  if [[ -z "$arg" ]] || [[ "${arg:0:1}" == "-" ]]; then
-    die "$opt requires <$type> argument"
-  fi
-}
-is_function_defined() {
-  declare -f "$1" > /dev/null
-}
-
-# Processes incoming arguments and places them in appropriate global variables.  called by the run method.
-process_args () {
-  while [[ $# -gt 0 ]]; do
-    case "$1" in
-       -h|-help) usage; exit 1 ;;
-    -v|-verbose) verbose=1 && shift ;;
-      -d|-debug) debug=1 && shift ;;
-
-           -mem) require_arg integer "$1" "$2" && app_mem="$2" && shift 2 ;;
-     -jvm-debug) require_arg port "$1" "$2" && addDebugger $2 && shift 2 ;;
-
-     -java-home) require_arg path "$1" "$2" && java_cmd="$2/bin/java" && shift 2 ;;
-
-            -D*) addJava "$1" && shift ;;
-            -J*) addJava "${1:2}" && shift ;;
-              *) addResidual "$1" && shift ;;
-    esac
-  done
-  
-  is_function_defined process_my_args && {
-    myargs=("${residual_args[@]}")
-    residual_args=()
-    process_my_args "${myargs[@]}"
-  }
-}
-
-# Actually runs the script.
-run() {
-  # TODO - check for sane environment
-
-  # process the combined args, then reset "$@" to the residuals
-  process_args "$@"
-  set -- "${residual_args[@]}"
-  argumentCount=$#
-
-  # run sbt
-  execRunner "$java_cmd" \
-    $(get_mem_opts $app_mem) \
-    ${java_opts} \
-    ${java_args[@]} \
-    -cp "$app_classpath" \
-    $app_mainclass \
-    "${app_commands[@]}" \
-    "${residual_args[@]}"
-}
-
-# Loads a configuration file full of default command line options for this script.
-loadConfigFile() {
-  cat "$1" | sed '/^\#/d'
-}
-
-###  ------------------------------- ###
-###  Start of customized settings    ###
-###  ------------------------------- ###
-"""
-    
-    
-  val template_footer = """
-
-###  ------------------------------- ###
-###  Main script                     ###
-###  ------------------------------- ###
-
-declare -a residual_args
-declare -a java_args
-declare -a app_commands
-declare java_cmd=java
-declare -r app_classpath="$lib_dir/*"
-
-
-# if configuration files exist, prepend their contents to $@ so it can be processed by this runner
-[[ -f "$script_conf_file" ]] && set -- $(loadConfigFile "$script_conf_file") "$@"
-
-run "$@"
-"""
 }
\ No newline at end of file
diff --git a/src/main/scala/com/typesafe/sbt/packager/universal/UniversalPlugin.scala b/src/main/scala/com/typesafe/sbt/packager/universal/UniversalPlugin.scala
index 625a75bd7..fe2285d49 100644
--- a/src/main/scala/com/typesafe/sbt/packager/universal/UniversalPlugin.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/universal/UniversalPlugin.scala
@@ -61,7 +61,9 @@ trait UniversalPlugin extends Plugin {
     // TODO - Config file user-readable permissions....
     for {
       (from, to) <- copies
+      _ = println("staged: " + to.getAbsolutePath)
       if from.canExecute
+      _ = println("executable: " + to.getAbsolutePath)
     } to.setExecutable(true)
   }
     
diff --git a/src/sbt-test/debian/java-app-archetype/build.sbt b/src/sbt-test/debian/java-app-archetype/build.sbt
new file mode 100644
index 000000000..35f3ce61a
--- /dev/null
+++ b/src/sbt-test/debian/java-app-archetype/build.sbt
@@ -0,0 +1,32 @@
+import NativePackagerKeys._
+
+packageArchetype.java_application
+
+name := "debian-test"
+
+version := "0.1.0"
+
+maintainer := "Josh Suereth <joshua.suereth@typesafe.com>"
+
+packageSummary := "Test debian package"
+
+packageDescription := """A fun package description of our software,
+  with multiple lines."""
+
+debianPackageDependencies in Debian ++= Seq("java2-runtime", "bash (>= 2.05a-11)")
+
+debianPackageRecommends in Debian += "git"
+
+
+TaskKey[Unit]("check-script") <<= (stagingDirectory in Universal, name, streams) map { (dir, name, streams) =>
+  val script = dir / "bin" / name
+  val cmd = "bash " + script.getAbsolutePath
+  val result =
+    Process(cmd) ! streams.log match {
+      case 0 => ()
+      case n => sys.error("Failed to run script: " + script.getAbsolutePath + " error code: " + n)
+    }
+  val output = Process("bash " + script.getAbsolutePath).!!
+  val expected = "SUCCESS!"
+  assert(output contains expected, "Failed to correctly run the main script!.  Found ["+output+"] wanted ["+expected+"]")
+}
diff --git a/src/sbt-test/debian/java-app-archetype/project/plugins.sbt b/src/sbt-test/debian/java-app-archetype/project/plugins.sbt
new file mode 100644
index 000000000..b53de154c
--- /dev/null
+++ b/src/sbt-test/debian/java-app-archetype/project/plugins.sbt
@@ -0,0 +1 @@
+addSbtPlugin("com.typesafe.sbt" % "sbt-native-packager" % sys.props("project.version"))
diff --git a/src/sbt-test/debian/java-app-archetype/src/main/scala/test/Test.scala b/src/sbt-test/debian/java-app-archetype/src/main/scala/test/Test.scala
new file mode 100644
index 000000000..242dc2381
--- /dev/null
+++ b/src/sbt-test/debian/java-app-archetype/src/main/scala/test/Test.scala
@@ -0,0 +1,5 @@
+package test
+
+object Test extends App {
+  println("SUCCESS!")
+}
diff --git a/src/sbt-test/debian/java-app-archetype/test b/src/sbt-test/debian/java-app-archetype/test
new file mode 100644
index 000000000..09a72e41b
--- /dev/null
+++ b/src/sbt-test/debian/java-app-archetype/test
@@ -0,0 +1,6 @@
+# Run the debian packaging.
+> debian:package-bin
+$ exists target/debian-test-0.1.0.deb
+> stage
+$ exists target/universal/stage/bin/debian-test
+> check-script
diff --git a/src/sbt-test/universal/dist/build.sbt b/src/sbt-test/universal/dist/build.sbt
new file mode 100644
index 000000000..8c687dea6
--- /dev/null
+++ b/src/sbt-test/universal/dist/build.sbt
@@ -0,0 +1,7 @@
+import NativePackagerKeys._
+
+packagerSettings
+
+name := "simple-test"
+
+version := "0.1.0"
diff --git a/src/sbt-test/universal/dist/project/plugins.sbt b/src/sbt-test/universal/dist/project/plugins.sbt
new file mode 100644
index 000000000..b53de154c
--- /dev/null
+++ b/src/sbt-test/universal/dist/project/plugins.sbt
@@ -0,0 +1 @@
+addSbtPlugin("com.typesafe.sbt" % "sbt-native-packager" % sys.props("project.version"))
diff --git a/src/sbt-test/universal/dist/src/universal/conf/test b/src/sbt-test/universal/dist/src/universal/conf/test
new file mode 100644
index 000000000..ab1006ffd
--- /dev/null
+++ b/src/sbt-test/universal/dist/src/universal/conf/test
@@ -0,0 +1 @@
+# Test configuration to include in zips.
diff --git a/src/sbt-test/universal/dist/test b/src/sbt-test/universal/dist/test
new file mode 100644
index 000000000..09179aca1
--- /dev/null
+++ b/src/sbt-test/universal/dist/test
@@ -0,0 +1,3 @@
+# Create the distribution and ensure files show up.
+> dist
+$ exists target/universal/simple-test-0.1.0.zip

From 4a06ae9f8bc557396be1cf398dcb98927d5e0c09 Mon Sep 17 00:00:00 2001
From: Josh Suereth <joshua.suereth@gmail.com>
Date: Wed, 10 Jul 2013 14:17:35 -0400
Subject: [PATCH 04/10] Add windows bat file generation (at least a start). 
 Still need to test in windows and not WINE.

---
 .../sbt/packager/archetypes/bat-template      | 102 ++++++++++++++++++
 .../com/typesafe/sbt/packager/Keys.scala      |   2 +-
 .../sbt/packager/archetypes/JavaApp.scala     |  14 +++
 .../archetypes/JavaAppBashScript.scala        |   1 -
 .../archetypes/JavaAppBatScript.scala         |  28 +++++
 .../packager/universal/UniversalPlugin.scala  |   2 -
 6 files changed, 145 insertions(+), 4 deletions(-)
 create mode 100644 src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template
 create mode 100644 src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBatScript.scala

diff --git a/src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template b/src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template
new file mode 100644
index 000000000..d8782769d
--- /dev/null
+++ b/src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template
@@ -0,0 +1,102 @@
+@REM @@APP_NAME@@ launcher script
+@REM
+@REM Envioronment:
+@REM JAVA_HOME - location of a JDK home dir (optional if java on path)
+@REM CFG_OPTS  - JVM options (optional)
+@REM Configuration:
+@REM @@APP_ENV_NAME@@_config.txt found in the @@APP_ENV_NAME@@_HOME.
+@setlocal enabledelayedexpansion
+
+@echo off
+if "%@@APP_ENV_NAME@@_HOME%"=="" set "@@APP_ENV_NAME@@_HOME=%~dp0\\.."
+set ERROR_CODE=0
+@@template_declares@@
+
+rem Detect if we were double clicked, although theoretically A user could
+rem manually run cmd /c
+for %%x in (%cmdcmdline%) do if %%~x==/c set DOUBLECLICKED=1
+
+rem FIRST we load the config file of extra options.
+set "CFG_FILE=%@@APP_ENV_NAME@@_HOME%@@APP_ENV_NAME@@_config.txt"
+set CFG_OPTS=
+if exist %CFG_FILE% (
+  FOR /F "tokens=* eol=# usebackq delims=" %%i IN ("%CFG_FILE%") DO (
+    set DO_NOT_REUSE_ME=%%i
+    rem ZOMG (Part #2) WE use !! here to delay the expansion of
+    rem CFG_OPTS, otherwise it remains "" for this loop.
+    set CFG_OPTS=!CFG_OPTS! !DO_NOT_REUSE_ME!
+  )
+)
+
+rem We use the value of the JAVACMD environment variable if defined
+set _JAVACMD=%JAVACMD%
+
+if "%_JAVACMD%"=="" (
+  if not "%JAVA_HOME%"=="" (
+    if exist "%JAVA_HOME%\bin\java.exe" set "_JAVACMD=%JAVA_HOME%\bin\java.exe"
+  )
+)
+
+if "%_JAVACMD%"=="" set _JAVACMD=java
+
+rem Detect if this java is ok to use.
+for /F %%j in ('"%_JAVACMD%" -version  2^>^&1') do (
+  if %%~j==Java set JAVAINSTALLED=1
+)
+
+rem Detect the same thing about javac
+if "%_JAVACCMD%"=="" (
+  if not "%JAVA_HOME%"=="" (
+    if exist "%JAVA_HOME%\bin\javac.exe" set "_JAVACCMD=%JAVA_HOME%\bin\javac.exe"
+  )
+)
+if "%_JAVACCMD%"=="" set _JAVACCMD=javac
+for /F %%j in ('"%_JAVACCMD%" -version 2^>^&1') do (
+  if %%~j==javac set JAVACINSTALLED=1
+)
+
+rem BAT has no logical or, so we do it OLD SCHOOL! Oppan Redmond Style
+set JAVAOK=true
+if not defined JAVAINSTALLED set JAVAOK=false
+rem TODO - JAVAC is an optional requirement.
+if not defined JAVACINSTALLED set JAVAOK=false
+
+if "%JAVAOK%"=="false" (
+  echo.
+  echo A Java JDK is not installed or can't be found.
+  if not "%JAVA_HOME%"=="" (
+    echo JAVA_HOME = "%JAVA_HOME%"
+  )
+  echo.
+  echo Please go to
+  echo   http://www.oracle.com/technetwork/java/javase/downloads/index.html
+  echo and download a valid Java JDK and install before running @@APP_NAME@@.
+  echo.
+  echo If you think this message is in error, please check
+  echo your environment variables to see if "java.exe" and "javac.exe" are
+  echo available via JAVA_HOME or PATH.
+  echo.
+  if defined DOUBLECLICKED pause
+  exit /B 1
+)
+
+
+rem We use the value of the JAVA_OPTS environment variable if defined, rather than the config.
+set _JAVA_OPTS=%JAVA_OPTS%
+if "%_JAVA_OPTS%"=="" set _JAVA_OPTS=%CFG_OPTS%
+
+:run
+
+rem TODO - figure out how to pass arguments....
+"%_JAVACMD%" %_JAVA_OPTS% %@@APP_ENV_NAME@@_OPTS% -cp "%@@APP_ENV_NAME@@_HOME%\lib\*" @@APP_MAIN_CLASS@@ %CMDS%
+if ERRORLEVEL 1 goto error
+goto end
+
+:error
+set ERROR_CODE=1
+
+:end
+
+@endlocal
+
+exit /B %ERROR_CODE%
\ No newline at end of file
diff --git a/src/main/scala/com/typesafe/sbt/packager/Keys.scala b/src/main/scala/com/typesafe/sbt/packager/Keys.scala
index 05fabc1f6..7efadfe83 100644
--- a/src/main/scala/com/typesafe/sbt/packager/Keys.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/Keys.scala
@@ -11,6 +11,6 @@ object Keys extends linux.Keys
   
   // TODO - Do these keys belong here?
   val makeBashScript = TaskKey[Option[File]]("makeBashScript", "Creates or discovers the bash script used by this project.")
-  val makeBinScript = TaskKey[File]("makeBashScript", "Creates or discovers the binscript used by this project.")
+  val makeBatScript = TaskKey[Option[File]]("makeBatScript", "Creates or discovers the bat script used by this project.")
   
 }
\ No newline at end of file
diff --git a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
index ca97fce58..dae77c5e8 100644
--- a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
@@ -24,10 +24,16 @@ object JavaAppPackaging {
       jar -> ("lib/" + jar.getName)
     },
     makeBashScript <<= (Keys.mainClass in Compile, target in Universal, name in Universal) map makeUniversalBinScript,
+    makeBatScript <<= (Keys.mainClass in Compile, target in Universal, name) map makeUniversalBatScript,
     mappings in Universal <++= (makeBashScript, name) map { (script, name) =>
       for {
         s <- script.toSeq  
       } yield s -> ("bin/" + name)
+    },
+    mappings in Universal <++= (makeBatScript, name) map { (script, name) =>
+      for {
+        s <- script.toSeq  
+      } yield s -> ("bin/" + name + ".bat")
     } 
   )
   
@@ -41,6 +47,14 @@ object JavaAppPackaging {
       script
     }
   
+  def makeUniversalBatScript(mainClass: Option[String], tmpDir: File, name: String): Option[File] = 
+    for(mc <- mainClass) yield {
+      val scriptBits = JavaAppBatScript.generateScript(name, mc)
+      val script = tmpDir / "tmp" / "bin" / (name + ".bat")
+      IO.write(script, scriptBits)
+      script
+    }
+  
   // Converts a managed classpath into a set of lib mappings.
   def universalDepMappings(deps: Seq[Attributed[File]]): Seq[(File,String)] = 
     for {
diff --git a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBashScript.scala b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBashScript.scala
index cf199806e..fcb7e1b08 100644
--- a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBashScript.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBashScript.scala
@@ -29,5 +29,4 @@ object JavaAppBashScript {
   def mainClassDefine(mainClass: String) = 
     "declare -r app_mainclass=\"%s\"\n" format (mainClass)
   
-  
 }
\ No newline at end of file
diff --git a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBatScript.scala b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBatScript.scala
new file mode 100644
index 000000000..5b2cd9d9d
--- /dev/null
+++ b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBatScript.scala
@@ -0,0 +1,28 @@
+package com.typesafe.sbt.packager.archetypes
+
+object JavaAppBatScript {
+   private[this] def bashTemplateSource =
+    getClass.getResource("bat-template")
+  private[this] def charset =
+    java.nio.charset.Charset.forName("UTF-8")
+    
+  def makeEnvFriendlyName(name: String): String =
+    name.toUpperCase.replaceAll("\\W", "_")   
+    
+   def generateScript(
+       name: String,
+       mainClass: String): String = {
+     val sb = new StringBuffer
+     for(line <- sbt.IO.readLinesURL(bashTemplateSource, charset)) {
+       
+       val fixed =
+         line.replaceAll("@@APP_NAME@@", name).
+              replaceAll("@@APP_MAIN_CLASS@@", mainClass).
+              replaceAll("@@APP_ENV_NAME@@", makeEnvFriendlyName(name))
+       
+       sb append fixed
+       sb append "\r\n"
+     }
+    sb.toString
+  }
+}
\ No newline at end of file
diff --git a/src/main/scala/com/typesafe/sbt/packager/universal/UniversalPlugin.scala b/src/main/scala/com/typesafe/sbt/packager/universal/UniversalPlugin.scala
index fe2285d49..625a75bd7 100644
--- a/src/main/scala/com/typesafe/sbt/packager/universal/UniversalPlugin.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/universal/UniversalPlugin.scala
@@ -61,9 +61,7 @@ trait UniversalPlugin extends Plugin {
     // TODO - Config file user-readable permissions....
     for {
       (from, to) <- copies
-      _ = println("staged: " + to.getAbsolutePath)
       if from.canExecute
-      _ = println("executable: " + to.getAbsolutePath)
     } to.setExecutable(true)
   }
     

From 1aceb6826f3331967a8f3f0a435073f4f04a90dd Mon Sep 17 00:00:00 2001
From: Josh Suereth <joshua.suereth@gmail.com>
Date: Wed, 10 Jul 2013 14:21:27 -0400
Subject: [PATCH 05/10] Bump documentation for archetypes.

---
 src/sphinx/archetypes.rst | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/src/sphinx/archetypes.rst b/src/sphinx/archetypes.rst
index 3b627ddd7..904a5df40 100644
--- a/src/sphinx/archetypes.rst
+++ b/src/sphinx/archetypes.rst
@@ -17,9 +17,6 @@ Curently, in the nativepackager these archetypes are available:
   * Java Command Line Application (Experimental)
   
 
-
-  
-
 Java Command Line Application
 -----------------------------
 
@@ -30,17 +27,13 @@ this archetype in your build, do the following in your ``build.sbt``:
 
     archetypes.java_application
 
-    mapGenericFilesToLinux
-
-    mapGenericFilesToWindows
-    
     name := "A-package-friendly-name"
     
     packageSummary in Linux := "The name you want displayed in package summaries"
 
     packageSummary in Windows := "The name you want displayed in Add/Remove Programs"
 
-    packageDescription := " A descriptioin of your project"
+    packageDescription := " A description of your project"
 
     maintainer in Windows := "Company"
     
@@ -49,3 +42,17 @@ this archetype in your build, do the following in your ``build.sbt``:
     wixProductId := "ce07be71-510d-414a-92d4-dff47631848a"
 
     wixProductUpgradeId := "4552fb0e-e257-4dbd-9ecb-dba9dbacf424"
+
+
+This archetype will use the ``mainClass`` setting of sbt (automatically discovers your main class) to generate ``bat`` and ``bin`` scripts for your project.  It
+produces a universal layout that looks like the following:
+
+
+    bin/
+      <app_name>       <- BASH script
+      <app_name>.bat   <- cmd.exe script
+    lib/
+       <Your project and dependent jar files here.>
+
+
+You can add additional files to the project by placeing things in ``src/windows``, ``src/universal`` or ``src/linux`` as needed.

From 7610b9fd435ad5d5dae1a6a70b0c74b5d121a9d5 Mon Sep 17 00:00:00 2001
From: Josh Suereth <joshua.suereth@gmail.com>
Date: Wed, 10 Jul 2013 16:27:10 -0400
Subject: [PATCH 06/10] Fix bat template to work in windows.

* Add \ where appropriate
* Remove @template_defines@ as it was unused.
---
 .../com/typesafe/sbt/packager/archetypes/bat-template          | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template b/src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template
index d8782769d..586541d15 100644
--- a/src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template
+++ b/src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template
@@ -10,14 +10,13 @@
 @echo off
 if "%@@APP_ENV_NAME@@_HOME%"=="" set "@@APP_ENV_NAME@@_HOME=%~dp0\\.."
 set ERROR_CODE=0
-@@template_declares@@
 
 rem Detect if we were double clicked, although theoretically A user could
 rem manually run cmd /c
 for %%x in (%cmdcmdline%) do if %%~x==/c set DOUBLECLICKED=1
 
 rem FIRST we load the config file of extra options.
-set "CFG_FILE=%@@APP_ENV_NAME@@_HOME%@@APP_ENV_NAME@@_config.txt"
+set "CFG_FILE=%@@APP_ENV_NAME@@_HOME%\@@APP_ENV_NAME@@_config.txt"
 set CFG_OPTS=
 if exist %CFG_FILE% (
   FOR /F "tokens=* eol=# usebackq delims=" %%i IN ("%CFG_FILE%") DO (

From 3f1838132c25c594b33a13ee8a5938d58e78e3e2 Mon Sep 17 00:00:00 2001
From: Josh Suereth <joshua.suereth@gmail.com>
Date: Wed, 10 Jul 2013 16:41:27 -0400
Subject: [PATCH 07/10] Fix bad escaping of identifiers in wix generation.

---
 .../com/typesafe/sbt/packager/GenericPackageSettings.scala     | 3 +--
 .../scala/com/typesafe/sbt/packager/windows/WixHelper.scala    | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/main/scala/com/typesafe/sbt/packager/GenericPackageSettings.scala b/src/main/scala/com/typesafe/sbt/packager/GenericPackageSettings.scala
index 9ae441730..651ed8b23 100644
--- a/src/main/scala/com/typesafe/sbt/packager/GenericPackageSettings.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/GenericPackageSettings.scala
@@ -113,14 +113,13 @@ trait GenericPackageSettings
       } yield ComponentFile(name, editable = (name startsWith "conf"))
     val corePackage =
       WindowsFeature(
-        id=name+"Core",
+        id=WixHelper.cleanStringForId(name+"_core"),
         title=name,
         desc="All core files.",
         absent="disallow",
         components = files
       )
     // TODO - Detect bat files to add paths...
-    val homeEnvVar = name.toUpperCase +"_HOME"
     val addBinToPath =
       // TODO - we may have issues here...
       WindowsFeature(
diff --git a/src/main/scala/com/typesafe/sbt/packager/windows/WixHelper.scala b/src/main/scala/com/typesafe/sbt/packager/windows/WixHelper.scala
index 5759e1904..d18bf3dec 100644
--- a/src/main/scala/com/typesafe/sbt/packager/windows/WixHelper.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/windows/WixHelper.scala
@@ -84,7 +84,7 @@ object WixHelper {
       case w: WindowsFeature => sys.error("Nested windows features currently unsupported!")
       case AddDirectoryToPath(dir) =>
         val dirRef = if(dir.isEmpty) "INSTALLDIR" else cleanStringForId(dir)
-        val homeEnvVar = name.toUpperCase + "_HOME"
+        val homeEnvVar = archetypes.JavaAppBatScript.makeEnvFriendlyName(name) +"_HOME"
         val pathAddition = 
           if(dir.isEmpty) "%"+homeEnvVar+"%"
           else "[INSTALLDIR]\\"+dir.replaceAll("\\/", "\\\\")

From e6696d7049c44191a66de08716beb0480ccac004 Mon Sep 17 00:00:00 2001
From: Josh Suereth <joshua.suereth@gmail.com>
Date: Wed, 10 Jul 2013 21:07:57 -0400
Subject: [PATCH 08/10] Fix lib filenames to match Play conventions.

---
 .../sbt/packager/archetypes/JavaApp.scala      | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
index dae77c5e8..003496df9 100644
--- a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
@@ -54,13 +54,25 @@ object JavaAppPackaging {
       IO.write(script, scriptBits)
       script
     }
-  
+
   // Converts a managed classpath into a set of lib mappings.
   def universalDepMappings(deps: Seq[Attributed[File]]): Seq[(File,String)] = 
     for {
       dep <- deps
       file = dep.data
-      // TODO - Figure out what to do with jar files.
       if file.isFile
-    } yield dep.data -> ("lib/" + dep.data.getName)
+      // TODO - Figure out what to do with jar files.
+    } yield {
+      val filename: Option[String] = for {
+            module <- dep.metadata.get(AttributeKey[ModuleID]("module-id"))
+            artifact <- dep.metadata.get(AttributeKey[Artifact]("artifact"))
+          } yield {
+            module.organization + "." +
+              module.name + "-" +
+              Option(artifact.name.replace(module.name, "")).filterNot(_.isEmpty).map(_ + "-").getOrElse("") +
+              module.revision + ".jar"
+      }
+        
+      dep.data -> ("lib/" + filename.getOrElse(file.getName))
+    }
 }
\ No newline at end of file

From f3772f422e129564588bca0f13eb0fd2f7b9e1ea Mon Sep 17 00:00:00 2001
From: Josh Suereth <joshua.suereth@gmail.com>
Date: Thu, 11 Jul 2013 10:11:47 -0400
Subject: [PATCH 09/10] Added some configuration of how template start scripts
 are generated.

* Use same classpath ordering as sbt in start scripts
* Allow user configuration of additional hooks for the script.

Review by @huntc to see if we're any closer to parity with Play.
---
 .../sbt/packager/archetypes/bash-template     | 15 ++--
 .../sbt/packager/archetypes/bat-template      |  7 +-
 .../com/typesafe/sbt/packager/Keys.scala      |  7 ++
 .../sbt/packager/archetypes/JavaApp.scala     | 71 +++++++++++++------
 .../archetypes/JavaAppBashScript.scala        | 35 +++++++--
 .../archetypes/JavaAppBatScript.scala         | 32 +++++++--
 6 files changed, 124 insertions(+), 43 deletions(-)

diff --git a/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template b/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template
index a74fe5d2a..878e414a5 100644
--- a/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template
+++ b/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template
@@ -137,16 +137,15 @@ is_function_defined() {
   declare -f "$1" > /dev/null
 }
 
-# If we're *not* running in a terminal, and we don't have any arguments, then we need to add the 'ui' parameter
+# Attempt to detect if the script is running via a GUI or not
+# TODO - Determine where/how we use this generically
 detect_terminal_for_ui() {
   [[ ! -t 0 ]] && [[ "${#residual_args}" == "0" ]] && {
-    addResidual "ui"
+    echo "true"
   }
   # SPECIAL TEST FOR MAC
   [[ "$(uname)" == "Darwin" ]] && [[ "$HOME" == "$PWD" ]] && [[ "${#residual_args}" == "0" ]] && {
-    echo "Detected MAC OSX launched script...."
-    echo "Swapping to UI"
-    addResidual "ui"
+    echo "true"
   }
 }
 
@@ -182,7 +181,6 @@ run() {
 
   # process the combined args, then reset "$@" to the residuals
   process_args "$@"
-  detect_terminal_for_ui
   set -- "${residual_args[@]}"
   argumentCount=$#
 
@@ -251,11 +249,10 @@ declare -a residual_args
 declare -a java_args
 declare -a app_commands
 declare -r app_home="$(realpath "$(dirname "$0")")"
-${{template_declares}}
-declare -r java_cmd=$(get_java_cmd)
 # TODO - Check whether this is ok in cygwin...
 declare -r lib_dir="${app_home}/../lib"
-declare -r app_classpath="$lib_dir/*"
+${{template_declares}}
+declare -r java_cmd=$(get_java_cmd)
 
 # Now check to see if it's a good enough version
 # TODO - Check to see if we have a configured default java version, otherwise use 1.6
diff --git a/src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template b/src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template
index 586541d15..11e398181 100644
--- a/src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template
+++ b/src/main/resources/com/typesafe/sbt/packager/archetypes/bat-template
@@ -11,6 +11,8 @@
 if "%@@APP_ENV_NAME@@_HOME%"=="" set "@@APP_ENV_NAME@@_HOME=%~dp0\\.."
 set ERROR_CODE=0
 
+set "APP_LIB_DIR=%@@APP_ENV_NAME@@_HOME%\lib\"
+
 rem Detect if we were double clicked, although theoretically A user could
 rem manually run cmd /c
 for %%x in (%cmdcmdline%) do if %%~x==/c set DOUBLECLICKED=1
@@ -85,9 +87,10 @@ set _JAVA_OPTS=%JAVA_OPTS%
 if "%_JAVA_OPTS%"=="" set _JAVA_OPTS=%CFG_OPTS%
 
 :run
-
+ 
+set "APP_CLASSPATH=@@APP_CLASSPATH@@"
 rem TODO - figure out how to pass arguments....
-"%_JAVACMD%" %_JAVA_OPTS% %@@APP_ENV_NAME@@_OPTS% -cp "%@@APP_ENV_NAME@@_HOME%\lib\*" @@APP_MAIN_CLASS@@ %CMDS%
+"%_JAVACMD%" %_JAVA_OPTS% %@@APP_ENV_NAME@@_OPTS% -cp "%APP_CLASSPATH%" @@APP_MAIN_CLASS@@ %CMDS%
 if ERRORLEVEL 1 goto error
 goto end
 
diff --git a/src/main/scala/com/typesafe/sbt/packager/Keys.scala b/src/main/scala/com/typesafe/sbt/packager/Keys.scala
index 7efadfe83..f04541e81 100644
--- a/src/main/scala/com/typesafe/sbt/packager/Keys.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/Keys.scala
@@ -10,7 +10,14 @@ object Keys extends linux.Keys
   with universal.UniversalKeys {
   
   // TODO - Do these keys belong here?
+
+  // These keys are used by the JavaApp archetype.
+  val classpathOrdering = TaskKey[Seq[(File, String)]]("classpathOrdering", "The order of the classpath used at runtime for the bat/bash scripts.")
   val makeBashScript = TaskKey[Option[File]]("makeBashScript", "Creates or discovers the bash script used by this project.")
+  val bashScriptDefines = TaskKey[Seq[String]]("bashScriptDefines", "A list of definitions that should be written to the bash file template.")
+  val bashScriptExtraDefines = TaskKey[Seq[String]]("bashScriptExtraDefines", "A list of extra definitions that should be written to the bash file template.")
+  val scriptClasspath = TaskKey[Seq[String]]("scriptClasspath", "A list of relative filenames (to the lib/ folder in the distribution) of what to include on the classpath.")
   val makeBatScript = TaskKey[Option[File]]("makeBatScript", "Creates or discovers the bat script used by this project.")
+  val batScriptReplacements = TaskKey[Seq[(String,String)]]("batScriptReplacements", "Replacements of template parameters used in the windows bat script.")
   
 }
\ No newline at end of file
diff --git a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
index 003496df9..39acc6f91 100644
--- a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
@@ -4,7 +4,7 @@ package archetypes
 
 import Keys._
 import sbt._
-import sbt.Keys.{mappings, target, name, mainClass}
+import sbt.Keys.{mappings, target, name, mainClass, normalizedName}
 import linux.LinuxPackageMapping
 import SbtNativePackager._
 
@@ -19,40 +19,71 @@ import SbtNativePackager._
 object JavaAppPackaging {
   
   def settings: Seq[Setting[_]] = Seq(
-    mappings in Universal <++= (Keys.managedClasspath in Compile) map universalDepMappings,
-    mappings in Universal <+= (Keys.packageBin in Compile) map { jar =>
-      jar -> ("lib/" + jar.getName)
+    // Here we record the classpath as it's added to the mappings separately, so
+    // we cna use it to generate the bash/bat scripts.
+    classpathOrdering := Nil, 
+    classpathOrdering <+= (Keys.packageBin in Compile) map { jar =>
+	  jar -> ("lib/" + jar.getName)
+	},
+    classpathOrdering <++= (Keys.managedClasspath in Compile) map universalDepMappings,
+    mappings in Universal <++= classpathOrdering,
+    scriptClasspath <<= classpathOrdering map makeRelativeClasspathNames, 
+    bashScriptExtraDefines := Nil,
+    bashScriptDefines <<= (Keys.mainClass in Compile, scriptClasspath, bashScriptExtraDefines) map { (mainClass, cp, extras) =>
+      val hasMain =
+        for {
+          cn <- mainClass
+        } yield JavaAppBashScript.makeDefines(cn, appClasspath = cp, extras = extras)
+      hasMain getOrElse Nil
     },
-    makeBashScript <<= (Keys.mainClass in Compile, target in Universal, name in Universal) map makeUniversalBinScript,
-    makeBatScript <<= (Keys.mainClass in Compile, target in Universal, name) map makeUniversalBatScript,
-    mappings in Universal <++= (makeBashScript, name) map { (script, name) =>
+    makeBashScript <<= (bashScriptDefines, target in Universal, normalizedName) map makeUniversalBinScript,
+    batScriptReplacements <<= (normalizedName, Keys.mainClass in Compile, scriptClasspath) map { (name, mainClass, cp) =>
+      mainClass map { mc => 
+        JavaAppBatScript.makeReplacements(name = name, mainClass = mc, appClasspath = cp)
+      } getOrElse Nil
+      
+    },
+    makeBatScript <<= (batScriptReplacements, target in Universal, normalizedName) map makeUniversalBatScript,
+    mappings in Universal <++= (makeBashScript, normalizedName) map { (script, name) =>
       for {
         s <- script.toSeq  
       } yield s -> ("bin/" + name)
     },
-    mappings in Universal <++= (makeBatScript, name) map { (script, name) =>
+    mappings in Universal <++= (makeBatScript, normalizedName) map { (script, name) =>
       for {
         s <- script.toSeq  
       } yield s -> ("bin/" + name + ".bat")
     } 
   )
   
-  def makeUniversalBinScript(mainClass: Option[String], tmpDir: File, name: String): Option[File] = 
-    for(mc <- mainClass) yield {
-      val scriptBits = JavaAppBashScript.generateScript(mc)
+  def makeRelativeClasspathNames(mappings: Seq[(File, String)]): Seq[String] =
+    for {
+      (file, name) <- mappings
+    } yield {
+      // Here we want the name relative to the lib/ folder...
+      // For now we just cheat...
+      if(name startsWith "lib/") name drop 4
+      else "../" + name
+    }
+  
+  def makeUniversalBinScript(defines: Seq[String], tmpDir: File, name: String): Option[File] = 
+    if(defines.isEmpty) None
+    else {
+      val scriptBits = JavaAppBashScript.generateScript(defines)
       val script = tmpDir / "tmp" / "bin" / name
       IO.write(script, scriptBits)
       // TODO - Better control over this!
       script.setExecutable(true)
-      script
+      Some(script)
     }
   
-  def makeUniversalBatScript(mainClass: Option[String], tmpDir: File, name: String): Option[File] = 
-    for(mc <- mainClass) yield {
-      val scriptBits = JavaAppBatScript.generateScript(name, mc)
+  def makeUniversalBatScript(replacements: Seq[(String, String)], tmpDir: File, name: String): Option[File] = 
+    if(replacements.isEmpty) None
+    else {
+      val scriptBits = JavaAppBatScript.generateScript(replacements)
       val script = tmpDir / "tmp" / "bin" / (name + ".bat")
       IO.write(script, scriptBits)
-      script
+      Some(script)
     }
 
   // Converts a managed classpath into a set of lib mappings.
@@ -64,10 +95,10 @@ object JavaAppPackaging {
       // TODO - Figure out what to do with jar files.
     } yield {
       val filename: Option[String] = for {
-            module <- dep.metadata.get(AttributeKey[ModuleID]("module-id"))
-            artifact <- dep.metadata.get(AttributeKey[Artifact]("artifact"))
-          } yield {
-            module.organization + "." +
+        module <- dep.metadata.get(AttributeKey[ModuleID]("module-id"))
+        artifact <- dep.metadata.get(AttributeKey[Artifact]("artifact"))
+      } yield {
+        module.organization + "." +
               module.name + "-" +
               Option(artifact.name.replace(module.name, "")).filterNot(_.isEmpty).map(_ + "-").getOrElse("") +
               module.revision + ".jar"
diff --git a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBashScript.scala b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBashScript.scala
index fcb7e1b08..c3fd4e412 100644
--- a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBashScript.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBashScript.scala
@@ -1,17 +1,42 @@
 package com.typesafe.sbt.packager.archetypes
 
+/**
+ * Constructs a bash script for running a java application.
+ * 
+ * Makes use of the associated bash-template, with a few hooks
+ * 
+ */
 object JavaAppBashScript {
   
   private[this] def bashTemplateSource =
     getClass.getResource("bash-template")
   private[this] def charset =
     java.nio.charset.Charset.forName("UTF-8")
-  def generateScript(mainClass: String,
-                     configFile: Option[String] = None): String = {
-     val sb = new StringBuffer
-     val defines: Seq[String] =
+    
+  /** Creates the block of defines for a script.
+   * 
+   * @param mainClass The required "main" method class we use to run the program.
+   * @param appClasspath A sequence of relative-locations (to the lib/ folder) of jars
+   *                     to include on the classpath.
+   * @param configFile An (optional) filename from which the script will read arguments.
+   * @param extras  Any additional defines/commands that should be run in this script. 
+   */
+  def makeDefines(
+      mainClass: String,
+      appClasspath: Seq[String] = Seq("*"),
+      configFile: Option[String] = None,
+      extras: Seq[String] = Nil): Seq[String] =
+       Seq(mainClassDefine(mainClass)) ++
        (configFile map configFileDefine).toSeq ++
-       Seq(mainClassDefine(mainClass))
+       Seq(makeClasspathDefine(appClasspath)) ++
+       extras
+       
+  private def makeClasspathDefine(cp: Seq[String]): String = {
+    val fullString = cp map (n => "$lib_dir/"+n) mkString ":"
+    "declare -r app_classpath=\""+fullString+"\"\n"
+  }  
+  def generateScript(defines: Seq[String]): String = {
+     val sb = new StringBuffer
      for(line <- sbt.IO.readLinesURL(bashTemplateSource, charset)) {
        if(line contains """${{template_declares}}""") {
          sb append (defines mkString "\n")
diff --git a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBatScript.scala b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBatScript.scala
index 5b2cd9d9d..94b57e466 100644
--- a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBatScript.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaAppBatScript.scala
@@ -8,18 +8,36 @@ object JavaAppBatScript {
     
   def makeEnvFriendlyName(name: String): String =
     name.toUpperCase.replaceAll("\\W", "_")   
+  
+  def makeWindowsRelativeClasspath(cp: Seq[String]): String = {
+     def cleanPath(path: String): String = path.replaceAll("/", "\\")
+     def makeRelativePath(path: String): String =
+       "%APP_LIB_DIR%\\" + cleanPath(path)
+     cp map makeRelativePath mkString ":"
+   }
+    // TODO - Allow recursive replacements....
+   def makeReplacements(
+       name: String, 
+       mainClass: String, 
+       appClasspath: Seq[String] = Seq("*"),
+       extras: Seq[(String,String)] = Nil): Seq[(String, String)] = {
+     Seq(
+         "APP_NAME" -> name,
+         "APP_MAIN_CLASS" -> mainClass,
+         "APP_ENV_NAME" -> makeEnvFriendlyName(name),
+         "APP_CLASSPATH" -> makeWindowsRelativeClasspath(appClasspath)
+     ) ++ extras
+   }
     
    def generateScript(
-       name: String,
-       mainClass: String): String = {
+       replacements: Seq[(String,String)]): String = {
      val sb = new StringBuffer
      for(line <- sbt.IO.readLinesURL(bashTemplateSource, charset)) {
-       
        val fixed =
-         line.replaceAll("@@APP_NAME@@", name).
-              replaceAll("@@APP_MAIN_CLASS@@", mainClass).
-              replaceAll("@@APP_ENV_NAME@@", makeEnvFriendlyName(name))
-       
+         replacements.foldLeft(line) { 
+           case (line, (key, value)) =>
+             line.replaceAll("@@"+key+"@@", java.util.regex.Matcher.quoteReplacement(value))
+         }
        sb append fixed
        sb append "\r\n"
      }

From bd83f04c9b9eda78e895fbd02403b85711c3297c Mon Sep 17 00:00:00 2001
From: Josh Suereth <joshua.suereth@gmail.com>
Date: Fri, 12 Jul 2013 13:02:18 -0400
Subject: [PATCH 10/10] Fixes from @huntc review.

* Consolidate names to use "script"
* Add better descriptions
* Update the docs a bit.
---
 .../typesafe/sbt/packager/archetypes/bash-template   |  4 +---
 src/main/scala/com/typesafe/sbt/packager/Keys.scala  |  9 +++++++--
 .../typesafe/sbt/packager/archetypes/JavaApp.scala   | 12 ++++++------
 src/sphinx/archetypes.rst                            |  2 +-
 4 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template b/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template
index 878e414a5..fea67e291 100644
--- a/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template
+++ b/src/main/resources/com/typesafe/sbt/packager/archetypes/bash-template
@@ -217,10 +217,8 @@ loadConfigFile() {
 ###  ------------------------------- ###
 usage() {
  cat <<EOM
-Usage: $script_name [ui] [options]
+Usage: $script_name [options]
 
-  ui                 starts the Activator UI
-  new                Create a new project from a template
   -h | -help         print this message
   -v | -verbose      this runner is chattier
   -d | -debug        set sbt log level to debug
diff --git a/src/main/scala/com/typesafe/sbt/packager/Keys.scala b/src/main/scala/com/typesafe/sbt/packager/Keys.scala
index f04541e81..06c08994c 100644
--- a/src/main/scala/com/typesafe/sbt/packager/Keys.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/Keys.scala
@@ -12,12 +12,17 @@ object Keys extends linux.Keys
   // TODO - Do these keys belong here?
 
   // These keys are used by the JavaApp archetype.
-  val classpathOrdering = TaskKey[Seq[(File, String)]]("classpathOrdering", "The order of the classpath used at runtime for the bat/bash scripts.")
   val makeBashScript = TaskKey[Option[File]]("makeBashScript", "Creates or discovers the bash script used by this project.")
   val bashScriptDefines = TaskKey[Seq[String]]("bashScriptDefines", "A list of definitions that should be written to the bash file template.")
   val bashScriptExtraDefines = TaskKey[Seq[String]]("bashScriptExtraDefines", "A list of extra definitions that should be written to the bash file template.")
+  val scriptClasspathOrdering = TaskKey[Seq[(File, String)]]("scriptClasspathOrdering", "The order of the classpath used at runtime for the bat/bash scripts.")
   val scriptClasspath = TaskKey[Seq[String]]("scriptClasspath", "A list of relative filenames (to the lib/ folder in the distribution) of what to include on the classpath.")
   val makeBatScript = TaskKey[Option[File]]("makeBatScript", "Creates or discovers the bat script used by this project.")
-  val batScriptReplacements = TaskKey[Seq[(String,String)]]("batScriptReplacements", "Replacements of template parameters used in the windows bat script.")
+  val batScriptReplacements = TaskKey[Seq[(String,String)]]("batScriptReplacements", 
+      """|Replacements of template parameters used in the windows bat script.
+         |  Default supported templates:
+         |  APP_ENV_NAME - the name of the application for defining <name>_HOME variables
+         |  APP_CLASSPATH - the string to use for teh classpath of java.
+         |  """.stripMargin)
   
 }
\ No newline at end of file
diff --git a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
index 39acc6f91..728f27085 100644
--- a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
+++ b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala
@@ -20,14 +20,14 @@ object JavaAppPackaging {
   
   def settings: Seq[Setting[_]] = Seq(
     // Here we record the classpath as it's added to the mappings separately, so
-    // we cna use it to generate the bash/bat scripts.
-    classpathOrdering := Nil, 
-    classpathOrdering <+= (Keys.packageBin in Compile) map { jar =>
+    // we can use its order to generate the bash/bat scripts.
+    scriptClasspathOrdering := Nil, 
+    scriptClasspathOrdering <+= (Keys.packageBin in Compile) map { jar =>
 	  jar -> ("lib/" + jar.getName)
 	},
-    classpathOrdering <++= (Keys.managedClasspath in Compile) map universalDepMappings,
-    mappings in Universal <++= classpathOrdering,
-    scriptClasspath <<= classpathOrdering map makeRelativeClasspathNames, 
+    scriptClasspathOrdering <++= (Keys.dependencyClasspath in Runtime) map universalDepMappings,
+    mappings in Universal <++= scriptClasspathOrdering,
+    scriptClasspath <<= scriptClasspathOrdering map makeRelativeClasspathNames, 
     bashScriptExtraDefines := Nil,
     bashScriptDefines <<= (Keys.mainClass in Compile, scriptClasspath, bashScriptExtraDefines) map { (mainClass, cp, extras) =>
       val hasMain =
diff --git a/src/sphinx/archetypes.rst b/src/sphinx/archetypes.rst
index 904a5df40..c12298180 100644
--- a/src/sphinx/archetypes.rst
+++ b/src/sphinx/archetypes.rst
@@ -55,4 +55,4 @@ produces a universal layout that looks like the following:
        <Your project and dependent jar files here.>
 
 
-You can add additional files to the project by placeing things in ``src/windows``, ``src/universal`` or ``src/linux`` as needed.
+You can add additional files to the project by placing things in ``src/windows``, ``src/universal`` or ``src/linux`` as needed.