Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly CLI backmerge #648

Merged
merged 12 commits into from
Dec 8, 2023
Merged

Weekly CLI backmerge #648

merged 12 commits into from
Dec 8, 2023

Conversation

technophile-04
Copy link
Collaborator

@technophile-04 technophile-04 commented Dec 7, 2023

Description

Copy link
Collaborator Author

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it thoroughly, once #649 is merged we can update it here and this is ready to go 🙌

@technophile-04 technophile-04 requested review from carletex, rin-st and damianmarti and removed request for carletex December 7, 2023 17:30
@technophile-04
Copy link
Collaborator Author

Tested it nicely, but would love if someone could do a basic pass 🙌

Also, we shouldn't squash & merge instead do a direct merge commit 🙌

Copy link
Member

@carletex carletex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working nicely.

Thanks Shiv!

@carletex carletex merged commit f516908 into cli Dec 8, 2023
@carletex carletex deleted the cli-backmerge branch December 8, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants