SE-597 - Upgrade Libs #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulraja
requested changes
Oct 17, 2016
| @@ -48,7 +46,7 @@ object ApplySection extends FlatSpec with Matchers with org.scalaexercises.defin | |||
| * Since `Apply` extends `Functor`, we can use the `map` method from `Functor`: | |||
| */ | |||
| def applyExtendsFunctor(res0: Option[String], res1: Option[Int], res2: Option[Int]) = { | |||
| import cats.std.all._ | |||
| import cats.implicits._ | |||
There was a problem hiding this comment.
I think these should have the actual import of the feature used which is a lot more precise than importing all of cats implicits.
There was a problem hiding this comment.
This PR has focused in the upgrading process. Maybe we could align the current cats documentation (like http://typelevel.org/cats/tut/apply.html) with the current implementation in scala-exercises in a different ticket: #46
Closed
|
@raulraja does it make sense? Thanks! |
raulraja
approved these changes
Oct 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to this other PR: scala-exercises/scala-exercises#599
It should be merged only once #599 is merged.
Additionally, it updates the cats exercises to align it with latest version (0.7.2) (import statements and some more things).
BTW, this PR fixes #39 and #36
Please, @raulraja could you review? Thanks.