From 3413591608de53304f587772742e94a754df8115 Mon Sep 17 00:00:00 2001 From: Ikenna Darlington Ogbajie Date: Fri, 24 Jun 2016 17:41:27 +0100 Subject: [PATCH 1/4] Update Lists.scala Updated Argument type to ``List[Int]``` --- src/main/scala/stdlib/Lists.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/scala/stdlib/Lists.scala b/src/main/scala/stdlib/Lists.scala index cbec1923..6260d52a 100644 --- a/src/main/scala/stdlib/Lists.scala +++ b/src/main/scala/stdlib/Lists.scala @@ -148,7 +148,7 @@ object Lists extends FlatSpec with Matchers with exercise.Section { /** Lists reuse their tails */ - def reuseTailsLists(res0: Int, res1: Int, res2: Int, res3: String, res4: String, res5: String) { + def reuseTailsLists(res0: Int, res1: Int, res2: Int, res3: List[Int], res4: List[Int], res5: List[Int]) { val d = Nil val c = 3 :: d val b = 2 :: c From 6d5a8a2bab9ab4d2746223bdf19b47c7663bceff Mon Sep 17 00:00:00 2001 From: Ikenna Darlington Ogbajie Date: Fri, 24 Jun 2016 17:48:12 +0100 Subject: [PATCH 2/4] Update ListsSpec.scala --- src/test/scala/exercises/stdlib/ListsSpec.scala | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/test/scala/exercises/stdlib/ListsSpec.scala b/src/test/scala/exercises/stdlib/ListsSpec.scala index 5beafa5c..d7712d0b 100644 --- a/src/test/scala/exercises/stdlib/ListsSpec.scala +++ b/src/test/scala/exercises/stdlib/ListsSpec.scala @@ -126,13 +126,12 @@ class ListsSpec extends Spec with Checkers { ) } - // FIXME: depends on #259 - // def `lists share tails` = { - // check( - // Test.testSuccess( - // Lists.reuseTailsLists _, - // HNil - // ) - // ) - // } + def `lists share tails` = { + check( + Test.testSuccess( + Lists.reuseTailsLists _, + List(2, 3) :: List(3) :: List[Int]() :: HNil + ) + ) + } } From 1bc1ee83dd0594bc335d454eed453e58065f8082 Mon Sep 17 00:00:00 2001 From: Ikenna Darlington Ogbajie Date: Fri, 24 Jun 2016 18:10:58 +0100 Subject: [PATCH 3/4] Update ListsSpec.scala --- src/test/scala/exercises/stdlib/ListsSpec.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/scala/exercises/stdlib/ListsSpec.scala b/src/test/scala/exercises/stdlib/ListsSpec.scala index d7712d0b..4d6898e0 100644 --- a/src/test/scala/exercises/stdlib/ListsSpec.scala +++ b/src/test/scala/exercises/stdlib/ListsSpec.scala @@ -130,7 +130,7 @@ class ListsSpec extends Spec with Checkers { check( Test.testSuccess( Lists.reuseTailsLists _, - List(2, 3) :: List(3) :: List[Int]() :: HNil + List(2, 3) ::: List(3) ::: List[Int]() ::: HNil ) ) } From 04e95f89abffa37f29ec93e9d880e14f6d5807b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20G=C3=B3mez?= Date: Mon, 27 Jun 2016 10:30:49 +0200 Subject: [PATCH 4/4] Fix test --- src/test/scala/exercises/stdlib/ListsSpec.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/scala/exercises/stdlib/ListsSpec.scala b/src/test/scala/exercises/stdlib/ListsSpec.scala index 4d6898e0..fa527a2f 100644 --- a/src/test/scala/exercises/stdlib/ListsSpec.scala +++ b/src/test/scala/exercises/stdlib/ListsSpec.scala @@ -130,7 +130,7 @@ class ListsSpec extends Spec with Checkers { check( Test.testSuccess( Lists.reuseTailsLists _, - List(2, 3) ::: List(3) ::: List[Int]() ::: HNil + 1 :: 2 :: 3 :: List(2, 3) :: List(3) :: List.empty[Int] :: HNil ) ) }