Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated rewrite of withFilter -> filter #8339

Closed
scabug opened this issue Feb 25, 2014 · 2 comments
Closed

remove deprecated rewrite of withFilter -> filter #8339

scabug opened this issue Feb 25, 2014 · 2 comments
Assignees
@adriaanm
Milestone
2.12.0-RC1

Comments

@scabug
Copy link

scabug commented Feb 25, 2014

Finally act on deprecation in #6455
@scabug
Copy link
Author

scabug commented Feb 25, 2014

Imported From: https://issues.scala-lang.org/browse/SI-8339?orig=1
Reporter: @adriaanm
See #6455

@scabug
Copy link
Author

scabug commented Jul 12, 2016

@adriaanm said:
scala/scala#5252

@scabug scabug closed this as completed Aug 19, 2016
@scabug scabug added this to the 2.12.0-RC1 milestone Apr 7, 2017
Blaisorblade added a commit to dotty-staging/dotty that referenced this issue May 30, 2018
@Blaisorblade
Stop rewriting withFilter to filter
b2b7a4f 
This was dropped for Scala 2 in scala/scala#5252 for
2.12.0-RC1, as discussed for instance in
scala/bug#6455 and
scala/bug#8339.
@Blaisorblade Blaisorblade mentioned this issue May 30, 2018
Merged
Blaisorblade added a commit to dotty-staging/dotty that referenced this issue May 30, 2018
@Blaisorblade
Stop rewriting withFilter to filter
7b9853a 
This was dropped for Scala 2 in scala/scala#5252 for 2.12.0-RC1, as discussed
for instance in scala/bug#6455 and scala/bug#8339.

Beyond this code, also remove `MaybeFilter` attachment and attending code
introduced in fcea3d5.

A caveat is that, unexpectedly, this code was added in 2016-08-24, after
scala/scala#5252 was merged, as if the decision was reversed; but scala#1461 says:

> Also, I went through tests in pending/pos and reclassified as far as possible.

So I assume this just happened because the Scala 2 PR didn't remove our pending
test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adriaanm adriaanm

Labels
None yet
Projects
None yet
Milestone
2.12.0-RC1
Development

No branches or pull requests
2 participants
@adriaanm @scabug