Clean-up the new lazy vals

Author: szymon-rd

bench-micro/results_isStable.json

@@ -1986,6 +1986,12 @@ class Definitions {
     addSyntheticSymbolsComments
   }
 
+  /** Definitions used in Lazy Vals implementation */
+  val LazyValsModuleName = "scala.runtime.LazyVals"
+  @tu lazy val LazyValsModule = requiredModule(LazyValsModuleName)
+  @tu lazy val LazyValsWaitingState = requiredClass(s"$LazyValsModuleName.Waiting")
+  @tu lazy val LazyValsControlState = requiredClass(s"$LazyValsModuleName.LazyValControlState")
+
   def addSyntheticSymbolsComments(using Context): Unit =
     def add(sym: Symbol, doc: String) = ctx.docCtx.foreach(_.addDocstring(sym, Some(Comment(NoSpan, doc))))
 

compiler/src/dotty/tools/dotc/core/Definitions.scala

@@ -481,6 +481,7 @@ class TreeChecker extends Phase with SymTransformer {
       def isAllowed(sym: Symbol): Boolean = sym.is(ConstructorProxy)
 
       val symbolsNotDefined = (decls -- defined - constr.symbol).filterNot(isAllowed)
+
       assert(symbolsNotDefined.isEmpty,
         i" $cls tree does not define members: ${symbolsNotDefined.toList}%, %\n" +
         i"expected: ${decls.toList}%, %\n" +

compiler/src/dotty/tools/dotc/transform/LazyVals.scala

@@ -34,4 +34,4 @@ t6278-synth-def.scala
 t6925b.scala
 t7011.scala
 t8306.scala
-zipped.scala
+zipped.scala

compiler/src/dotty/tools/dotc/transform/TreeChecker.scala

@@ -1,2 +1,2 @@
 # CI only: cannot reduce summonFrom with
-sip23-valueof.scala
+sip23-valueof.scala

compiler/test/dotc/pos-lazy-vals-tests.allowlist

@@ -63,4 +63,4 @@ t7406.scala
 t8245.scala
 unapply.scala
 unit-lazy-val.scala
-view-iterator-stream.scala
+view-iterator-stream.scala

compiler/test/dotc/run-from-tasty.blacklist

@@ -43,4 +43,4 @@ i12753
 t6138
 t6138-2
 i12656.scala
-trait-static-forwarder
+trait-static-forwarder

compiler/test/dotc/run-lazy-vals-tests.allowlist

@@ -10,4 +10,4 @@ i5976.scala
 tagless.scala
 safeThrowsStrawman2.scala
 t7584.scala
-function-arity.scala
+function-arity.scala

compiler/test/dotc/run-test-pickling.blacklist

@@ -163,20 +163,11 @@ object LazyVals {
 
 
   object Names {
-    final val controlState = "LazyValControlState"
-    final val waiting = "Waiting"
-    final val evaluating = "Evaluating"
-    final val nullValue = "NullValue"
-    final val waitingAwaitRelease = "await"
-    final val waitingRelease = "countDown"
     final val state = "STATE"
     final val cas = "CAS"
-    final val objCas = "objCAS"
     final val setFlag = "setFlag"
     final val wait4Notification = "wait4Notification"
     final val get = "get"
     final val getOffset = "getOffset"
-    final val getOffsetStatic = "getOffsetStatic"
-    final val getStaticFieldOffset = "getStaticFieldOffset"
   }
 }