Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: TopLevel implicit is now allowed, remove unnecessary checking for toplevel implicits #14935

Merged
merged 1 commit into from
Apr 22, 2022
Merged

refactor: TopLevel implicit is now allowed, remove unnecessary checking for toplevel implicits #14935

merged 1 commit into from
Apr 22, 2022

Commits on Apr 22, 2022

  1. refactor: TopLevel implicit is now allowed 

    It seems like TopLevelCantBeImplicit is no longer the case as of scala#5754
And it is actually confirmed in https://github.com/lampepfl/dotty/blob/93fc41fcb624df73cc12d52b79d518a30a778a7c/tests/run/toplevel-implicits/a.b.scala#L19-L21

This commit replace the unnecessary check in from Checking.scala to
assertion and deleted the `ErrorMessage` definition for `TopLevelCantBeImplicit`.

I'm leaving the `TopLevelCantBeImplicitID` in `ErrorMessageID.scala` so
we don't screw up the error number.
    @tanishiking
    tanishiking committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    6442498 View commit details
    Browse the repository at this point in the history