-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative scheme for cc encapsulation #18899
Merged
Merged
Commits on Nov 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f7c9595 - Browse repository at this point
Copy the full SHA f7c9595View commit details -
Configuration menu - View commit details
-
Copy full SHA for 648665d - Browse repository at this point
Copy the full SHA 648665dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1290f1 - Browse repository at this point
Copy the full SHA d1290f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a17d8f4 - Browse repository at this point
Copy the full SHA a17d8f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b58ae96 - Browse repository at this point
Copy the full SHA b58ae96View commit details -
This adds reach capabilities x* as described in the proposal.
Configuration menu - View commit details
-
Copy full SHA for beffc7e - Browse repository at this point
Copy the full SHA beffc7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 484e3e8 - Browse repository at this point
Copy the full SHA 484e3e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f72c941 - Browse repository at this point
Copy the full SHA f72c941View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2546ade - Browse repository at this point
Copy the full SHA 2546adeView commit details -
Configuration menu - View commit details
-
Copy full SHA for da4d512 - Browse repository at this point
Copy the full SHA da4d512View commit details -
Require
cap
to be imported fromcaps
.Since it is never necessary to write `cap` explicitly, there's no need to treat the identifier as a soft keyword.
Configuration menu - View commit details
-
Copy full SHA for 927dec1 - Browse repository at this point
Copy the full SHA 927dec1View commit details -
Treat all type parameters and abstract types as sealed
This means that no type parameter can be instantiated with a type that captures cap covariantly or invariantly in its type. Two exceptions/special cases: - Type arguments for isInstanceOf and asInstanceOf are excluded, they can capture cap anywhere. - Refining variables in class types can still contain cap since they describe what comes from the constructor. Test reclassifications: - i15922.scala was moved to pending. Not clear whether this should compile, and what changes would be necessary to get it there. - future-traverse.scala was moved to pending. Not clear how to make this compiler. - i15749a.scala was moved to neg. The issue description seems to indicate that the test should not compile, but I am not sure what the outcome should be.
Configuration menu - View commit details
-
Copy full SHA for c1fc2c7 - Browse repository at this point
Copy the full SHA c1fc2c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e038b78 - Browse repository at this point
Copy the full SHA e038b78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fc6005 - Browse repository at this point
Copy the full SHA 2fc6005View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8f17a1 - Browse repository at this point
Copy the full SHA d8f17a1View commit details -
For some reason, http4s in the CB fails compilation otherwise. It's not clear what the failure has to do with the addition of $reach to Any, but it goes away when $reach has Method flag.
Configuration menu - View commit details
-
Copy full SHA for 6ac0439 - Browse repository at this point
Copy the full SHA 6ac0439View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61a55d3 - Browse repository at this point
Copy the full SHA 61a55d3View commit details
Commits on Nov 15, 2023
-
Make $reach a SyntehticArtifact
That way it does not show up in completion suggestions
Configuration menu - View commit details
-
Copy full SHA for b176eca - Browse repository at this point
Copy the full SHA b176ecaView commit details -
Streamline treatment of CaptureRefs
- use isTrackableRef everywhere for discrimination (instead of just checking the CaptureRef type) - streamline treatment of reach refs through `stripReach`
Configuration menu - View commit details
-
Copy full SHA for f6d7a91 - Browse repository at this point
Copy the full SHA f6d7a91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e4cd60 - Browse repository at this point
Copy the full SHA 6e4cd60View commit details
Commits on Nov 16, 2023
-
- For i15922, it should not work, as both bad1 and bad2 leak scoped capabilities. It is moved to neg tests. - For future-traverse.scala, we could make it work this way. Previously it won't compile because we instantiated the type parameter of `successful` with a universal capability, but actually we needn't do that: we could well pick a local reach capability, as is done in this commit. - For i15749a.scala, it should work but sadly not right now, due to a limitation of our current implementation.
Configuration menu - View commit details
-
Copy full SHA for 032fe8a - Browse repository at this point
Copy the full SHA 032fe8aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.