Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten closure extractor in TreeInfo #21621

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Sep 20, 2024

The previous extractor for closures matches also arbitrary blocks that ended in a (possible deeply nested) closure. This caused wrong use sets in #21620. The new definition is stricter. There is also a new blockEndingInclosure extractor that keeps the old behavior.

Fixes #21620

The previous extractor for closures matches also arbitrary blocks that ended in a
(possible deeply nested) closure. This caused wrong use sets in scala#21620. The new
definition is stricter. There is also a new blockEndingInclosure extractor that
keeps the old behavior.

Fixes scala#21620
Co-authored-by: Dale Wijnand <dale.wijnand@gmail.com>
@odersky odersky merged commit 22ed2fb into scala:main Sep 22, 2024
28 checks passed
@odersky odersky deleted the fix-21620 branch September 22, 2024 15:14
@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Captures of curried function are incorrectly dropped
3 participants