Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment: restrict allowed trees in annotations #21840

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Experiment: restrict allowed trees in annotations #21840

wants to merge 9 commits into from

Commits on Nov 13, 2024

  1. Restrict allowed trees in annotations

    @mbovel
    mbovel committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    da97deb View commit details
    Browse the repository at this point in the history

  2. Fix betasty unpickling error with invalid annotations 

    Throw away erroneous trees to avoid unpickling issues in best-effort mode.

Co-Authored-By: Kacper Korban <kacper.f.korban@gmail.com>
    @mbovel @KacperFKorban
    mbovel and KacperFKorban committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d9ba132 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Allow New, Select, Block, ValDef, DefDef, Closure and EmptyTree 

    And use a TreeMap for the annotation check
    @mbovel
    mbovel committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    872459d View commit details
    Browse the repository at this point in the history

  2. Allow This and Inlined, enable checks for retains annotations

    @mbovel
    mbovel committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    5d668e6 View commit details
    Browse the repository at this point in the history

  3. Allow Quote and If

    @mbovel
    mbovel committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    040ec39 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. Discard the full annotation tree if a sub-tree is invalid

    @mbovel
    mbovel committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    dd3b668 View commit details
    Browse the repository at this point in the history

  2. Reject all trees that define symbols in annotations

    @mbovel
    mbovel committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    924ea08 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Reject splices and quotes in annotations

    @mbovel
    mbovel committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fcbb372 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Do not lift annotation arguments

    @mbovel
    mbovel committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    84d83e3 View commit details
    Browse the repository at this point in the history