From 602f659926b8e1cc2ac0f68cda0595761a19e258 Mon Sep 17 00:00:00 2001 From: Nicolas Stucki Date: Tue, 31 Oct 2023 09:11:23 +0100 Subject: [PATCH] Remove `stdlib213` from community build tests This test exists for historical reasons. Now we compile the Scala 2 library in the `scala2-library-bootstrapped` project. This one checks that it compiles (with `-Ycheck:all`) and is used to package the TASTy files in the `scala2-library-tasty` project. Furthermore, now there is a `scala/scala` test that checks that the library can be compiled with Scala 3. This test is fundamentally broken but we have not noticed it because we do not use `-Ycheck:all`. The reason is that when we compile `scala.Predef` we get a conflict with `scala.runtime.stdLibPatches.Predef` when we patch the symbols. This also surfaced in #18738. [Cherry-picked 8c6f4c7cade55ff0951cc8e3c7ae59b0d50e9deb] --- .../src/scala/dotty/communitybuild/projects.scala | 9 --------- .../scala/dotty/communitybuild/CommunityBuildTest.scala | 1 - 2 files changed, 10 deletions(-) diff --git a/community-build/src/scala/dotty/communitybuild/projects.scala b/community-build/src/scala/dotty/communitybuild/projects.scala index 49c0263f6c73..a425f38b117e 100644 --- a/community-build/src/scala/dotty/communitybuild/projects.scala +++ b/community-build/src/scala/dotty/communitybuild/projects.scala @@ -358,14 +358,6 @@ object projects: // sbtDocCommand = "dotty-community-build/doc" ) - lazy val stdLib213 = SbtCommunityProject( - project = "stdLib213", - extraSbtArgs = List("-Dscala.build.compileWithDotty=true"), - sbtTestCommand = """set Global / fatalWarnings := false; library/compile""", - sbtPublishCommand = """set Global / fatalWarnings := false; set library/Compile/packageDoc/publishArtifact := false; library/publishLocal""", - // sbtDocCommand = "library/doc" // Does no compile? No idea :/ - ) - lazy val shapeless3 = SbtCommunityProject( project = "shapeless-3", sbtTestCommand = List( @@ -796,7 +788,6 @@ def allProjects = List( projects.scalaPB, projects.minitest, projects.fastparse, - projects.stdLib213, projects.shapeless3, projects.xmlInterpolator, projects.effpi, diff --git a/community-build/test/scala/dotty/communitybuild/CommunityBuildTest.scala b/community-build/test/scala/dotty/communitybuild/CommunityBuildTest.scala index 6a4f832ce05a..9a4965577cf1 100644 --- a/community-build/test/scala/dotty/communitybuild/CommunityBuildTest.scala +++ b/community-build/test/scala/dotty/communitybuild/CommunityBuildTest.scala @@ -95,7 +95,6 @@ class CommunityBuildTestC: @Test def sourcecode = projects.sourcecode.run() @Test def specs2 = projects.specs2.run() - @Test def stdLib213 = projects.stdLib213.run() @Test def ujson = projects.ujson.run() @Test def upickle = projects.upickle.run() @Test def utest = projects.utest.run()