Skip to content

chore: drop toOption (deadcode) #24660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamzaremmal merged 1 commit into from
Dec 5, 2025
+1 −5
Merged

chore: drop toOption (deadcode) #24660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions compiler/src/dotty/tools/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ package object tools {
*/
transparent inline def uncheckedNN: T = x.asInstanceOf[T]

inline def toOption: Option[T] =
if x == null then None else Some(x.asInstanceOf[T])
end extension

object resultWrapper {
Expand Down
1 change: 0 additions & 1 deletion compiler/test/dotty/tools/dotc/sbt/ProgressCallbackTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import dotty.tools.dotc.sbt.ProgressCallbackTest.*
import org.junit.Assert.*
import org.junit.Test

import dotty.tools.toOption
import dotty.tools.dotc.core.Contexts.Context
import dotty.tools.dotc.core.Contexts.ctx
import dotty.tools.dotc.CompilationUnit
Expand Down
3 changes: 1 addition & 2 deletions presentation-compiler/src/main/dotty/tools/pc/completions/MatchCaseCompletions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import scala.meta.internal.pc.CompletionFuzzy
import scala.meta.pc.PresentationCompilerConfig
import scala.meta.pc.SymbolSearch

import dotty.tools.toOption
import dotty.tools.dotc.ast.tpd.*
import dotty.tools.dotc.core.Constants.Constant
import dotty.tools.dotc.core.Contexts.Context
Expand Down Expand Up @@ -135,7 +134,7 @@ object CaseKeywordCompletion:
),
Nil,
range = Some(completionPos.toEditRange),
command = config.parameterHintsCommand().toOption.flatMap(_.asScala),
command = Option(config.parameterHintsCommand()).flatMap(_.asScala),
)
)
else Nil
Expand Down
Loading