Support scala android plugin on Gradle #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Spurious test failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any Gradle Android projects only get a
javasection not ascalasection in the Bloop json exports because there's no real link between the Android sourcesets and java/scala sourcesets so theScalaCompileinfo is just floating about.This PR assumes that if the project has
ScalaCompileapplied to it then that info should be exported.So https://github.com/dsvdsv/scala-android-plugin is now supported. It looks dead as it doesn't support later versions of Gradle or Android, but why not.
I've left the test for it commented out as the
GradleRunnerseems to apply plugins in a different order than real-life Gradle so the test fails on configuration. Testing this on a localbuild.gradlefile appears to work.Hopefully this should solve scalameta/metals#4036