From dca79f318f47846e5c211b8fd77ec3ce86bf7acf Mon Sep 17 00:00:00 2001 From: Brice Jaglin Date: Sun, 1 May 2022 23:25:13 +0200 Subject: [PATCH] Update scalameta, semanticdb-scalac-core, ... to 4.5.5 semanticdb-scalac & scalameta parser behavior regarding Term.ApplyInfix is now aligned with Scala 3 (parens tokens are no longer included). This bugfix will cause Term.ApplyInfix single-arg lookup to fail if scalafix is ran against semanticdb files generated with older semanticdb-scalac because of the mismatch in arg position. --- project/Dependencies.scala | 2 +- .../scalafix/tests/v1/SymbolSuite.scala | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) rename scalafix-tests/unit/src/test/{scala-target2 => scala}/scalafix/tests/v1/SymbolSuite.scala (83%) diff --git a/project/Dependencies.scala b/project/Dependencies.scala index 64c9be046..0004d4119 100644 --- a/project/Dependencies.scala +++ b/project/Dependencies.scala @@ -33,7 +33,7 @@ object Dependencies { val nailgunV = "0.9.1" val scalaXmlV = "2.1.0" val scalaXml211V = "1.3.0" // scala-xml stops publishing for scala 2.11 - val scalametaV = "4.5.4" + val scalametaV = "4.5.5" val scalatestV = "3.0.8" // don't bump, to avoid forcing breaking changes on clients via eviction val bijectionCore = "com.twitter" %% "bijection-core" % bijectionCoreV diff --git a/scalafix-tests/unit/src/test/scala-target2/scalafix/tests/v1/SymbolSuite.scala b/scalafix-tests/unit/src/test/scala/scalafix/tests/v1/SymbolSuite.scala similarity index 83% rename from scalafix-tests/unit/src/test/scala-target2/scalafix/tests/v1/SymbolSuite.scala rename to scalafix-tests/unit/src/test/scala/scalafix/tests/v1/SymbolSuite.scala index cc7acaf2f..bf176bea1 100644 --- a/scalafix-tests/unit/src/test/scala-target2/scalafix/tests/v1/SymbolSuite.scala +++ b/scalafix-tests/unit/src/test/scala/scalafix/tests/v1/SymbolSuite.scala @@ -22,9 +22,6 @@ class SymbolSuite extends munit.FunSuite { case Term.ApplyInfix(_, Term.Name("shouldBe"), _, arg :: Nil) => arg } - // The symbol lookup fails against Scala 3.1.1 SemanticDB as the position - // there excludes surrounding parentheses while 2.x (scalac-semanticdb) and - // the parser include them assertNotEquals(arg.symbol, Symbol.None) }