adding possibility to specify custom repositories for coursier (#1521) #1586
Conversation
| @@ -91,7 +91,7 @@ class ScalafmtDynamicDownloader( | |||
| "https://oss.sonatype.org/content/repositories/snapshots" | |||
| ), | |||
| MavenRepository.of("https://oss.sonatype.org/content/repositories/public") | |||
| ) | |||
| ) ++ customRepositories | |||
There was a problem hiding this comment.
i think custom repos should either override the defaults, or have higher priority - one usecase of this (ours) is that oss repositories are disabled and must go through our own artifactory and it causes timeouts when trying to download stuff from OSS ... therefore it makes sense to try custom repositories first and fallback on defaults
There was a problem hiding this comment.
timeouts are good point, will move it in the front then
slivkamiro
force-pushed
the
resolvers
branch
2 times, most recently
from
a724e32
to
2c9c15f
Compare
|
@slivkamiro thank you so much for this! |
| /** | ||
| * Use this repositories to resolve dependencies. | ||
| */ | ||
| Scalafmt withRepositories(String ... repositories); |
There was a problem hiding this comment.
Let's make it clear that these must be Maven repositories
| Scalafmt withRepositories(String ... repositories); | |
| Scalafmt withMavenRepositories(String ... repositories); |
There was a problem hiding this comment.
no problem, I will amend the commit if you don't mind
Yes, see scalameta/sbt-scalafmt#73 |
I'm kind of lost in tests. I would need help with writing a test for ScalafmtDynamicDownloader, if necessary (I haven't found any).
I'm also struggling with sbt-scalafmt part. I can't find a way how to map resolvers configuration into list of string urls. Any ideas?