Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScalafmtReflectConfig: add access to indents #2919

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

kitbellew
Copy link
Collaborator

No description provided.

@kitbellew
Copy link
Collaborator Author

@unkarjedy should we consider adding to the main codebase the logic you added to intellij, and simply switch to using it?

@unkarjedy
Copy link
Contributor

@kitbellew
Yeah, my initial commit in IntelliJ was named

2/11/2019 12:19 temporary copied sources of scalafmt-dynamic #SCL-14957
JetBrains/intellij-scala@03adc3e

🤦‍♂️

It just ("simply" 😃) requires some effort.
We need to:

  1. find/review all patches in IntelliJ copy of scalafmt.dynamic
    (they were required to properly work with IntelliJ and it was much easier to patch it within IntelliJ repo)
  2. extract required abstractions to traits in order the patched version doesn't rely on IntelliJ implementation classes
    Example of such abstraction: artifact downloader
  3. pass those abstractions via some parameters
  4. move this to scalameta/scalafmt repo and ensure it works well

I never got to this because it worked fine and we always have something major to do 😑

@kitbellew kitbellew merged commit 9c00aa3 into scalameta:master Nov 24, 2021
@kitbellew kitbellew deleted the 2919 branch November 24, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants