ScalafmtDynamic: use dependency injection #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Nov 26, 2021
|
@tgodzik initially, attempted to follow @unkarjedy suggestion, made in #2919, to pave the way for intellij to use scalafmt-dynamic. one small part of this commit (extracted dependencies) has helped achieve that goal, but i found that intellij uses a vastly different approach to referring to files (uses virtual files which might not be represented by an nio.Path), which for now limits the ability to adopt the rest. wonder how scalafmt is invoked in metals, could you help me find that, @tgodzik? |
It's being done here: https://github.com/scalameta/metals/blob/main/metals/src/main/scala/scala/meta/internal/metals/FormattingProvider.scala#L551 |
Split both ScalafmtDynamic and ScalafmtDynamicDownloader into traits and implementations: - ScalafmtDynamicDownloader: replaced with: - Dependency: exposes dependencies, doesn't force coursier - DependencyDownloader: downloads dependencies, has coursier implementation - ScalafmtDynamic: split into below types, some injected as dependencies - ScalafmtProperties: contains all properties set via Scalafmt interface - ScalafmtModuleLoader: loads ScalafmtReflect, uses cache and dependency downloader - ScalafmtConfigLoader: loads ScalafmtReflectConfig, uses cache and module loader - ScalafmtDynamicSession: implements ScalafmtSession, uses properties and reflect config This will allow more complex clients (such as Intellij scala plugin) to remove some legacy custom code and use scalafmt-dynamic better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.