Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatTokens: implement isEnclosedInParens #3214

Merged
merged 3 commits into from
May 16, 2022
Merged

Conversation

kitbellew
Copy link
Collaborator

This method will apply only to parens, not just any matching delimiters, and will in the future also include those just outside the tree.

@kitbellew kitbellew requested review from tgodzik and dos65 May 14, 2022 22:42
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good! Is it only a refactoring or doe sit fix something?

@kitbellew
Copy link
Collaborator Author

The change looks good! Is it only a refactoring or doe sit fix something?

needed for upgrade to next parser version, which excludes parens from tree positions. oh, that simple change is really hard on the formatter.

@kitbellew kitbellew merged commit 1aec4c7 into scalameta:master May 16, 2022
@kitbellew kitbellew deleted the 3214 branch May 16, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants