Skip to content

Conversation

@feeblefakie
Copy link
Contributor

This is an automated backport of the following:

Please merge this PR after all checks have passed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated backport that integrates support for deprecated command-line interface arguments into the Data Loader. The primary goal is to maintain backward compatibility, allowing older CLI commands to function while guiding users towards newer, more explicit options. It includes robust validation to prevent conflicting argument usage and logic to correctly interpret and apply values from deprecated options when they are exclusively used.

Highlights

  • Deprecated CLI Argument Support: The Data Loader CLI now supports deprecated arguments for both export and import commands, ensuring backward compatibility for existing scripts and workflows.
  • Conflict Validation: A new validation mechanism has been implemented to prevent users from specifying both a deprecated argument and its modern replacement simultaneously, throwing an error to avoid ambiguous behavior.
  • Automatic Value Application: When only deprecated arguments are provided, their values are automatically applied to the corresponding new options, including inverted logic for 'exclusive' vs 'inclusive' scan boundaries.
  • Enhanced Test Coverage: New unit tests have been added to thoroughly verify the correct handling, validation, and application of both deprecated and new command-line options.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a backport that adds support for deprecated CLI arguments in the Data Loader to maintain backward compatibility. The changes are well-executed, introducing new options while hiding the old ones, and implementing validation to prevent their simultaneous use. The logic for handling deprecated arguments is correctly implemented and functions as intended. The new functionality is thoroughly covered by unit tests, which validate both the error conditions and the correct application of deprecated option values. The code is clean and adheres to best practices for CLI argument handling with picocli. Overall, the changes are solid and I have no specific feedback for improvement.

@brfrn169 brfrn169 merged commit baa393a into 3 Nov 6, 2025
310 of 315 checks passed
@brfrn169 brfrn169 deleted the 3-pull-3041 branch November 6, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants