From 9b9db18737d982dfb9d0104a424646e9928d223e Mon Sep 17 00:00:00 2001 From: KillianG Date: Thu, 21 Nov 2024 16:33:33 +0100 Subject: [PATCH] Refactor MongoConfigManager to use Promises for MongoDB connection handling and improve error logging --- .../configManager/MongoConfigManager.js | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/extensions/notification/configManager/MongoConfigManager.js b/extensions/notification/configManager/MongoConfigManager.js index 18eba3f1b..7434fca7d 100644 --- a/extensions/notification/configManager/MongoConfigManager.js +++ b/extensions/notification/configManager/MongoConfigManager.js @@ -100,15 +100,7 @@ class MongoConfigManager extends BaseConfigManager { MongoClient.connect(mongoUrl, { replicaSet: this._mongoConfig.replicaSet, useNewUrlParser: true, - }, - (err, client) => { - if (err) { - this._logger.error('Could not connect to MongoDB', { - method: 'MongoConfigManager._setupMongoClient', - error: err.message, - }); - return cb(err); - } + }).then((client) => { this._logger.debug('Connected to MongoDB', { method: 'MongoConfigManager._setupMongoClient', }); @@ -133,6 +125,12 @@ class MongoConfigManager extends BaseConfigManager { } catch (error) { return cb(error); } + }).catch(err => { + this._logger.error('Could not connect to MongoDB', { + method: 'MongoConfigManager._setupMongoClient', + error: err.message, + }); + return cb(err); }); }