Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BVV to 0.3.3 #680

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Update BVV to 0.3.3 #680

merged 2 commits into from
Feb 8, 2024

Conversation

kephale
Copy link
Member

@kephale kephale commented Feb 3, 2024

skalarproduktraum
skalarproduktraum requested changes Feb 5, 2024
View reviewed changes
Copy link
Member

@skalarproduktraum skalarproduktraum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but you lost a parameter in the change :-D

src/main/kotlin/graphics/scenery/volumes/VolumeManager.kt Outdated Show resolved Hide resolved
@skalarproduktraum skalarproduktraum merged commit 51310c9 into main Feb 8, 2024
6 checks passed
@skalarproduktraum skalarproduktraum deleted the bvv-0.3.3 branch February 8, 2024 18:42
@skalarproduktraum
Copy link
Member

Thanks, @kephale 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skalarproduktraum skalarproduktraum skalarproduktraum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kephale @skalarproduktraum