This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
Capturing raw metadata for OAI parsing of works #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we didn't capture the raw metadata of works parsed via OAI-PMH. With this change, we now capture that information. Below is an example showing that we need to use the record's `metadata` as a string. ```ruby gem "oai" require 'oai' client = OAI::Client.new( "http://oai.adventistdigitallibrary.org/OAI-script", headers: { from: "jeremy@scientist.com" }, parser: 'libxml') opts = { metadata_prefix: "oai_adl", set: "adl:issue" } records = client.list_records(opts) records.each_with_index do |r, i| puts "Working on record ##{i+1}" puts "Metadata:\n#{r.metadata.to_s}" end ``` Related to: samvera/bulkrax#694
jpengst
reviewed
Dec 21, 2022
| # who's ancestors include this ref. | ||
| # rubocop:disable Metrics/LineLength | ||
| gem 'bulkrax', "~> 4.4", git: "https://github.com/samvera-labs/bulkrax.git", ref: "d36cf3606545ea30da8d8082f1b67b96d9aaf8c1" | ||
| gem 'bulkrax', "~> 4.4", git: "https://github.com/samvera-labs/bulkrax.git", ref: "d1d0eca5963fcd190955ab75bcf9d0285afa2bb2" |
There was a problem hiding this comment.
I don't think ive seen ref's like this before. Does this point to a bulkrax commit or something?
There was a problem hiding this comment.
This does point to a specific commit on the main branch.
jpengst
approved these changes
Dec 21, 2022
jeremyf
added a commit
that referenced
this pull request
Dec 22, 2022
> Moving OAI metadata capture to entry processing > > In writing samvera/bulkrax#694 I introduced an OAI bug. There > are two OAI fetch cycles. > >The first is the list of records. These are fetched via the >`list_identifiers` method. That method returns header information >without metadata. Then, we submit one job per header. At that point >we perform the second fetch of the record. This includes the full >metadata. Related to: - samvera/bulkrax#697 - samvera/bulkrax#694 - #211
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we didn't capture the raw metadata of works parsed via OAI-PMH.
From the Bulkrax change:
With this change, we now capture that information.
Below is an example showing that we need to use the record's
metadataas a string.Related to: samvera/bulkrax#694